EndOfScrollList event for Autocomplete (Infinite scroll list) #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #2035 +/- ##
=========================================
- Coverage 64.11% 64% -0.12%
=========================================
Files 69 69
Lines 2469 2478 +9
Branches 798 801 +3
=========================================
+ Hits 1583 1586 +3
- Misses 816 822 +6
Partials 70 70
Continue to review full report at Codecov.
|
…mpatibility." This reverts commit e732dde.
LeoMouyna
pushed a commit
to LeoMouyna/buefy
that referenced
this pull request
Jan 6, 2020
* Updates node-sass dependency version to 4.12.0 for Node 12 compatibility. * Proposes endOfScrollList event logic, aiming infinite scroll requested on buefy#1842. * Changes endOfScrollList event name to infiniteScroll. * Adds checkInfiniteScroll prop to control listener of infiniteScroll. * Revert "Updates node-sass dependency version to 4.12.0 for Node 12 compatibility." This reverts commit e732dde. * Kebab notation to event and props.
LeoMouyna
pushed a commit
to LeoMouyna/buefy
that referenced
this pull request
Jan 6, 2020
* Updates node-sass dependency version to 4.12.0 for Node 12 compatibility. * Proposes endOfScrollList event logic, aiming infinite scroll requested on buefy#1842. * Changes endOfScrollList event name to infiniteScroll. * Adds checkInfiniteScroll prop to control listener of infiniteScroll. * Revert "Updates node-sass dependency version to 4.12.0 for Node 12 compatibility." This reverts commit e732dde. * Kebab notation to event and props.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (partially) #1842
Proposed Changes
endOfScrollList()when scroll reaches the end of list.Not sure if it's all clear. Also, I updated
node-sassdependency for providing support to Node 12. Let me know if it is a problem.