When checking pelican-generated output it segfaults on 'folder'

[iranzo]

 iranzo   source  ~  www  output  link-checker index.html 
Testing: index.html
  [████████████------------------------]   33%  00:00:07  Item 12/36
Traceback (most recent call last):
  File "/home/iranzo/.bin/link-checker", line 10, in <module>
    sys.exit(check())
  File "/home/iranzo/.local/venvs/link-checker/lib/python3.7/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/home/iranzo/.local/venvs/link-checker/lib/python3.7/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/home/iranzo/.local/venvs/link-checker/lib/python3.7/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/iranzo/.local/venvs/link-checker/lib/python3.7/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/home/iranzo/.local/venvs/link-checker/lib/python3.7/site-packages/checker.py", line 267, in check
    checker.test_items(items)
  File "/home/iranzo/.local/venvs/link-checker/lib/python3.7/site-packages/checker.py", line 201, in test_items
    self.test_file(item)
  File "/home/iranzo/.local/venvs/link-checker/lib/python3.7/site-packages/checker.py", line 188, in test_file
    self.test_link(lnk, fname)
  File "/home/iranzo/.local/venvs/link-checker/lib/python3.7/site-packages/checker.py", line 169, in test_link
    if not self._test_link(link, external):
  File "/home/iranzo/.local/venvs/link-checker/lib/python3.7/site-packages/checker.py", line 150, in _test_link
    ret = self._test_file_fragment(base_link, fragment)
  File "/home/iranzo/.local/venvs/link-checker/lib/python3.7/site-packages/checker.py", line 235, in _test_file_fragment
    with open(fname) as fdata:
IsADirectoryError: [Errno 21] Is a directory: '/home/iranzo/DEVEL/private/www/output/categories'

Cause is because Pelican, when rendered over http will server categories/index.html even if the link is /categories/

Code should contain logic so that when it finds a file, do not attempt to open that file but 'index.htm or index.html' (which are usually the standard ones)

[budziq]

Hi @iranzo, thanks for the report. I currently do not have capacity to tackle this problem in upcoming days but I'd be more than willing to accept a PR!

[iranzo]

I did a small attempt on the segfaulting line to check if folder or file and then append several common names, but seemed to hang I'll try to debug it more and submit it Regards Sent from mobile El vie., 24 may. 2019 18:44, Michał Budzyński <[email protected]> escribió:

…

Hi @iranzo <https://github.com/iranzo>, thanks for the report. I currently do not have capacity to tackle this problem in upcoming days but I'd be more than willing to accept a PR! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5?email_source=notifications&email_token=AACMJDYOOHVULZ3TBE5QZOLPXALO3A5CNFSM4HPQAJK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWF5VKA#issuecomment-495704744>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACMJD3F3YFSJIPD4JMBHNDPXALO3ANCNFSM4HPQAJKQ> .