Bring back custom translation files for BuddyPress! #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the `'load_translation_file'` filter to check custom file locations for the `buddypress` text domain. **NB**: this filter was introduced by WordPress in version 6.5. If there's a `buddypress-xx_XX.mo` (where xx_XX is the locale code) file into one of the following directories, it will be used to replace the default one (WordPress.org Plugin Directory / GlotPress).
…nslation_file'` filter This will be the case for WordPress 6.5 as `$locale` 3rd filter argument was introduced in WP 6.6.
|
FYI, I've also added a function to override default JavaScript translation files used in BP Blocks. |
dcavins
pushed a commit
to dcavins/buddypress-wp-svn
that referenced
this pull request
Jul 3, 2024
Prior to WordPress 4.6, it was possible to completely override the translation file with a custom one from one of the `'buddypress_locale_locations'` filterable list items. With WordPress 6.5 latest improvements about l10n, we are now able to bring these back. Making it easier for users to customize every BuddyPress strings should help them build match their community needs (e.g.: using sport/school/working/any other wording). 3 functions has been introduced: - `bp_get_custom_translation_file()` is looking for a file name into `'buddypress_locale_locations'` filterable list items. - `bp_load_custom_translation_file()` is the `'load_translation_file'` filter callback for regular translation files. - `bp_load_custom_script_translation_file()` is the `'load_script_translation_file'` filter callback for JavaScript translation files. The `bp_core_load_buddypress_textdomain()` function has been deprecated as it was pretty useless since WordPress 4.6. Props espellcaste Fixes #9187 Closes buddypress/buddypress#316 git-svn-id: http:https://buddypress.svn.wordpress.org/trunk@13936 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
'load_translation_file'filter to check custom file locations for thebuddypresstext domain.NB: this filter was introduced by WordPress in version 6.5.
If there's a
buddypress-xx_XX.mo(where xx_XX is the locale code) file into one of the following directories, it will be used to replace the default one (WordPress.org Plugin Directory / GlotPress):/wp-content/languages/plugins/buddypress(added in 14.0.0)/wp-content/languages/buddypress/wp-content/languagesTrac ticket: https://buddypress.trac.wordpress.org/ticket/9187
This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.