Review the bp_view capability support in endpoints
#506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bp_view capability support in endpoints
|
Just a note that the GraphQL API, renatonascalves/wp-graphql-buddypress#124, took a different approach. We don't return an error but rather an empty result. Mainly because in GraphQL, fields can be nested (connections). |
imath
reviewed
May 21, 2024
There was a problem hiding this comment.
Hi @renatonascalves another great job on this one 💪 . I would only remove the 'bp_view' check cap you added into the signups endpoint as anyway a higher cap is needed ('edit_users' or 'manage_network_users')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bp_viewcapability support in endpoints #496