Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the consumer grp test to contain less branches #322

Merged
merged 5 commits into from
Jul 29, 2020

Conversation

lanwen
Copy link
Collaborator

@lanwen lanwen commented May 19, 2020

Otherwise I always have hard times to follow the test flow without debug
Also it seems that test is named slightly incorrect, as it's one grp
but multiple consumers. Maybe not the best name for now, but hopefully better
than incorrect

Otherwise I always have hard times to follow the test flow without debug
Also it seems that test is named slightly incorrect, as it's one grp
but multiple consumers. Maybe not the best name for now, but hopefully better
than incorrect
@lanwen lanwen requested a review from bsideup May 19, 2020 15:49
}
});
await
.conditionEvaluationListener(onFailedCondition(() -> lastOffsets.putAll(publishToEveryPartition())))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's extract and reuse it

@bsideup bsideup merged commit cd5966e into master Jul 29, 2020
@bsideup bsideup added this to the next milestone Jul 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the test_multigrp_ref branch July 29, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants