Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't generate random names to read end offsets in subscription #263

Merged
merged 2 commits into from
Feb 13, 2020
Merged

Don't generate random names to read end offsets in subscription #263

merged 2 commits into from
Feb 13, 2020

Conversation

lanwen
Copy link
Collaborator

@lanwen lanwen commented Feb 13, 2020

image

simple query from pulsar via prometheus sum(pulsar_subscription_msg_throughput_out) by (subscription) gives this weird picture. I have to manually cleanup all of those subscriptions after each end offsets call

@lanwen lanwen requested a review from bsideup February 13, 2020 14:21
@bsideup bsideup added this to the next milestone Feb 13, 2020
@bsideup bsideup added plugin/pulsar enhancement New feature or request labels Feb 13, 2020
@bsideup bsideup merged commit 99d1c88 into master Feb 13, 2020
@bsideup bsideup deleted the const_subscr branch February 13, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsideup bsideup bsideup approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request plugin/pulsar
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.
2 participants
@lanwen @bsideup