-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pluggable customizers for GRPC transport via configurer beans #230
Conversation
...nsport/src/main/java/com/github/bsideup/liiklus/transport/grpc/config/GRPCConfiguration.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests? :)
Should I play with different classloaders somehow? Will the one plugin find beans of another plugin that easily? Seems this part is not exactly clear for me for now. |
@lanwen plugins use |
...rt/src/test/java/com/github/bsideup/liiklus/transport/grpc/config/GRPCConfigurationTest.java
Outdated
Show resolved
Hide resolved
...rt/src/test/java/com/github/bsideup/liiklus/transport/grpc/config/GRPCConfigurationTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR just opens the way on more lightweight plugins to add something for the GRPC transport. E.g. auth.
The approach is quite simple, so if it's fine, I'll add some tests.