Plugins #2
Plugins #2
Conversation
| for (String libDirectory : this.pluginClasspath.getLibDirectories()) { | ||
| Path libPath = jarFileSystem.getPath(libDirectory); | ||
| if (Files.exists(libPath)) { | ||
| Files.walk(libPath, 1).filter(it -> !Files.isDirectory(it)).forEach(it -> { |
There was a problem hiding this comment.
should you close this stream?
| Files.copy(it, tempFile, StandardCopyOption.REPLACE_EXISTING); | ||
| pluginClassLoader.addURL(tempFile.toUri().toURL()); | ||
| } catch (Exception e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
I remember fixing it o_O anyways, fixed now :)
| @FieldDefaults(makeFinal = true) | ||
| public class RecordPostProcessorChain { | ||
|
|
||
| Collection<RecordPostProcessor> processors; |
There was a problem hiding this comment.
is better to store it as List explicitly indicating that collection is sorted?
There was a problem hiding this comment.
no, did it intentionally, see TODO in getAll. Chains should sort them explicitly (will be added later)
| compileOnly project(":api") | ||
| compileOnly 'io.projectreactor:reactor-core' | ||
|
|
||
| compile ('com.amazonaws:aws-java-sdk-dynamodb:1.11.192') { |
There was a problem hiding this comment.
the same version as it used to be, don't want to do the dependencies update during this PR, might cause hidden issues
|
|
||
| @Bean | ||
| InMemoryPositionsStorage inMemoryPositionsStorage() { | ||
| PositionsStorage inMemoryPositionsStorage() { | ||
| log.warn("\n" + | ||
| String.format("%0106d", 0).replace("0", "=") + "\n" + |
There was a problem hiding this comment.
===================================================
:D
| @Override | ||
| @SneakyThrows | ||
| public List<Path> getPluginPaths() { | ||
| PathMatcher[] matchers = Stream.of(liiklusPluginManager.getPluginsPathMatcher().split("/")) |
There was a problem hiding this comment.
will it grab plugins./**/*.jar (for any depth pattern)?
| pluginClassLoader.addFile(pluginPath.toFile()); | ||
| } | ||
|
|
||
| protected void loadJars(Path pluginPath, PluginClassLoader pluginClassLoader) { |
No description provided.