Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulsar: use publishTime if eventTime is not set #177

Merged
merged 1 commit into from
Aug 29, 2019

Conversation

bsideup
Copy link
Owner

@bsideup bsideup commented Aug 29, 2019

extracted from #176

@bsideup bsideup added this to the next milestone Aug 29, 2019
@bsideup
Copy link
Owner Author

bsideup commented Aug 29, 2019

@Rowanto could you please take a look and confirm that the change looks good and matches yours?

@Rowanto
Copy link
Contributor

Rowanto commented Aug 29, 2019

yep, looks good.

@bsideup bsideup merged commit 1fa886e into master Aug 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the Rowanto_fix_pulsar_timestamp branch August 29, 2019 15:03
@bsideup
Copy link
Owner Author

bsideup commented Aug 29, 2019

@Rowanto thanks!

@Rowanto
Copy link
Contributor

Rowanto commented Aug 29, 2019

sorry, just realized there is another test missing, which is checking that eventTime is preferred over publish time @bsideup

@bsideup
Copy link
Owner Author

bsideup commented Aug 29, 2019

@Rowanto ooops, missed that one. Would you like to submit it or I should?
I guess it can be done from GitHub UI:
https://github.com/bsideup/liiklus/blob/master/plugins/pulsar-records-storage/src/test/java/com/github/bsideup/liiklus/pulsar/PulsarRecordsStorageTest.java

@bsideup
Copy link
Owner Author

bsideup commented Aug 29, 2019

@Rowanto I submitted #178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants