Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace reactor-kafka with plain consumer #15

Merged
merged 4 commits into from
Oct 4, 2018
Merged

Replace reactor-kafka with plain consumer #15

merged 4 commits into from
Oct 4, 2018
+294 −337

Conversation

bsideup
Copy link
Owner

@bsideup bsideup commented Sep 30, 2018

This is a temporary solution until reactor-kafka supports "source per partition" scenario

@bsideup bsideup requested a review from lanwen September 30, 2018 20:09
@bsideup bsideup added this to the next milestone Oct 4, 2018
lanwen
lanwen approved these changes Oct 4, 2018
View reviewed changes
Copy link
Collaborator

@lanwen lanwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the only question is about concurrency

@bsideup bsideup merged commit ceab137 into master Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanwen lanwen lanwen approved these changes

Assignees
No one assigned
Labels
plugin/kafka
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bsideup @lanwen