[pull] main from forem:main #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Bumps [@storybook/preact](https://github.com/storybookjs/storybook/tree/HEAD/app/preact) from 6.4.9 to 6.4.10. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.4.10/app/preact) --- updated-dependencies: - dependency-name: "@storybook/preact" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Initial work * Implement strategy injection into WeightedQueryStrategy * Modify field_test config and adding variants * Change orginal to constant and make some other adjustments * Fix hardcoded test values
Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.9.3 to 1.9.4. - [Release notes](https://github.com/Shopify/bootsnap/releases) - [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md) - [Commits](Shopify/bootsnap@v1.9.3...v1.9.4) --- updated-dependencies: - dependency-name: bootsnap dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* raise error with invalid embed url * fix spec; update docs
* Name the created after timestamp and remove temporary variables The logic used to calculate the live at time, the week ago time, then compare them to find the more recent value. Move all of this logic to a method (there's a guard to exit if the setting is nil, so this should be safe). * Mark method private This is not part of the public api (for workers, this should be `#perform` alone). Mark it private
…16060) * Modify welcome notification generator to handle errors per-message The original flow aborted all processing when any ActiveRecord::RecordNotFound exception was raised. This causes a situation where a missing broadcast message (by title) causes that notification message to fail, and each day the same failure to occur (since it wasn't successfully sent the day before), blocking all further messages. We want these to proceed on the schedule implicit in the checks, and failing early prevents that. Modify the error handling to catch RecordNotFound on each message, and continue throught the checks until a notification is enqueued or all checks have been attempted. * Run welcome broadcast check 4 hours after the user was created This started to fail when I modified the generator (why? because the user was 7 days old and _other_ notifications would be sent). Ensure the user is 4 hours old before checking that the disabled welcome broadcast message is checked, and not sent.
* Generator output Add your logic here! * replicate the logic from the forem connect migration * Add data update script This will generate the expected broadcast message to fix #16059 * Add apple connect to seeds file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )