Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for undefined addResizedColumns config #94

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

blerrgh
Copy link
Contributor

@blerrgh blerrgh commented Jan 4, 2023

Fixes error if no configuration dictionary is passed to addResizedColumns.

	const table = createTable(data, {
		resize: addResizedColumns(),
	});

TypeError: Cannot destructure property 'onResizeEnd' of 'undefined' as it is undefined.

Fixes "TypeError: Cannot destructure property 'onResizeEnd' of 'undefined' as it is undefined." when no configuration dictionary is passed to addResizedColumns
@vercel
Copy link

vercel bot commented Jan 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
svelte-headless-table ✅ Ready (Inspect) Visit Preview Jan 4, 2023 at 1:55AM (UTC)

Copy link
Owner

@bryanmylee bryanmylee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix! It's an oversight on my part.

Can you run npm run format, then bump the version to 0.16.2? I don't have any CI in place to automatically patch the versions just yet, so you'll have to edit package.json.

@blerrgh
Copy link
Contributor Author

blerrgh commented Jan 4, 2023

Yeah easy fix, I'm just working on hacking in some server side api features and noticed the error.

Version number updated! Thanks, and happy New Year!

@bryanmylee bryanmylee merged commit d941454 into bryanmylee:main Jan 4, 2023
@bryanmylee bryanmylee added the bug Something isn't working label Jan 4, 2023
@bryanmylee bryanmylee added this to the v1.0.0 milestone Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants