Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make header as column's alternative id #118

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

risalfajar
Copy link
Contributor

Fixes #114

I'm new into these things, so please check the code and let me know what you think.

@vercel
Copy link

vercel bot commented Mar 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-headless-table ❌ Failed (Inspect) Apr 5, 2023 5:08pm

@risalfajar
Copy link
Contributor Author

Hello @bryanmylee could you check this?

Copy link
Owner

@bryanmylee bryanmylee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great! Thanks for the PR :) I'll bump the versions and merge asap

@bryanmylee
Copy link
Owner

@risalfajar Can you update the version in package.json to 0.17.3, run npm i, then update the PR?

@risalfajar
Copy link
Contributor Author

Done!

@risalfajar
Copy link
Contributor Author

Hello @bryanmylee I just noticed that the docs aren't being updated even though I've updated the .md file, is there a problem with the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make id optional
2 participants