Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #11 #12

Merged

Conversation

bernardmcmanus
Copy link
Contributor

No description provided.

Copy link
Member

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I'm sorry that it has lingered for so long… I left some small comments, are you still interested in finishing this up?

util.js Outdated Show resolved Hide resolved
util.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@Hypercubed
Copy link

Hypercubed commented Oct 30, 2018

This is pretty old... but I'm hitting this issue now. Are we planning to get this chang in?

@bernardmcmanus
Copy link
Contributor Author

Wow it's been a while - yup I'll clean this up and then I assume we can get it merged

cc @goto-bus-stop

@bernardmcmanus
Copy link
Contributor Author

@Hypercubed OOC, do you know if this happens with webpack?

@bernardmcmanus
Copy link
Contributor Author

@goto-bus-stop updated

@Hypercubed
Copy link

@bernardmcmanus I'm seeing it in an Angular app, which is using webpack. But I'mn not loading util directly... it's a dep of a dep.

@goto-bus-stop goto-bus-stop self-requested a review October 31, 2018 08:33
Copy link
Member

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@goto-bus-stop goto-bus-stop merged commit 65f0f47 into browserify:master Nov 1, 2018
@goto-bus-stop
Copy link
Member

📦 0.11.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants