Skip to content

Commit

Permalink
Remove notice of build directory on activation
Browse files Browse the repository at this point in the history
I removed the notice of which build directory the extension will use.
It seems unnecessary. Also, it can change after activation.
  • Loading branch information
brobeson committed Oct 9, 2022
1 parent 121c549 commit 36d7ab3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ This file documents all notable changes to the CTest Lab extension.
- `CTest: Discover Tests` command:
[#18](https://github.com/brobeson/ctest-lab/issues/18)
- Use VS Code's `Test: Refresh Tests` command, instead.
- Notice of which build directory CTest Lab will use when the extension
activates.

## [0.2.0] — 2022-09-06

Expand Down
10 changes: 0 additions & 10 deletions src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,6 @@ export function activate(context: vscode.ExtensionContext) {
context.subscriptions.push(log_channel);
log_channel.appendLine("CTest Lab is available.");

// TODO Probably delete these blocks. Do users really need to know this?
if (
vscode.workspace.getConfiguration("cmake").get("buildDirectory") ===
undefined
) {
vscode.window.showWarningMessage(
"Setting 'cmake.buildDirectory' not found. Falling back to 'ctest-lab.buildDirectory'."
);
}

const controller = vscode.tests.createTestController(
"ctest-lab-tests",
"CTest"
Expand Down

0 comments on commit 36d7ab3

Please sign in to comment.