Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose checkIfSpotifyAppIsActive on iOS #105

Merged
merged 4 commits into from
Jun 6, 2021

Conversation

fotiDim
Copy link
Collaborator

@fotiDim fotiDim commented Jun 1, 2021

Another countermeasure for #86. I am exposing the checkIfSpotifyAppIsActive method from the native iOS SDK. This method works without connection to the Spotify app.

@brim-borium can we implement something similar for Android even if it has to be "with connection"? In practice we need a boolean indicating if music is playing or not on the Spotify app. Perhaps we can reuse PlayerContext.

@fotiDim fotiDim requested a review from brim-borium June 1, 2021 14:46
@brim-borium
Copy link
Owner

@brim-borium can we implement something similar for Android even if it has to be "with connection"? In practice we need a boolean indicating if music is playing or not on the Spotify app. Perhaps we can reuse PlayerContext.

I will check whether this is possible or not :)

Copy link
Owner

@brim-borium brim-borium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, if possible I will try to implement something like this for android on a separate branch

@brim-borium
Copy link
Owner

@fotiDim created #108 this should do the trick

@fotiDim fotiDim merged commit c3413bc into main Jun 6, 2021
@fotiDim fotiDim deleted the expose-checkIfSpotifyAppIsActive-ios branch August 22, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants