Set synaptic propagation modes only if variables are modified #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we just checked for occurences of `_postsynaptic_idx`, `_presynaptic_idx` and `_idx`. But just reading them doesn't lead to race conditions.
denisalevi
force-pushed
the
make_synaptic_propagation_modes_depend_on_writes_only
branch
from
5fa0b91
to
83b1db6
Compare
denisalevi
deleted the
make_synaptic_propagation_modes_depend_on_writes_only
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now we just checked for occurences of
_postsynaptic_idx,_presynaptic_idxand_idxinvariable_indicespassed toCUDAStandaloneDevice.code_object(). But just reading variables doesn't lead torace conditions, so we need to check for variables that will be written to in
vector_code.Tests running now.