Fix statemonitor #279
Merged
Fix statemonitor #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the index that determines parallelization over threads, hence this should be used for checking which threads return.
Fixes bug in #201, without optimizing it yet.
Now it actually tests something instead just failing to notify about issue #201 (which is solved now)
Previously, they were unnecessarily copied them to device memory at each time step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes StateMonitor to work with >1024 recorded neurons. And removes some unnecessary copying of
Nandtvariables between host and device memory.This closes #201
Some further straight forward optimizations of the
StateMonitorare collected in #278