-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nicer example plots #277
Nicer example plots #277
Conversation
Thanks @mstimberg, looks great!
|
Sure, will do.
It was a bit of a compromise to see the weight distribution changing in the last plot, but happy to run it for 10s (maybe making the runtime a command line argument?)
I agree, but for consistency it would be nice if the same (or at least a similar) plot gets generated when you run |
4e2b8ea
to
d8ebaf2
Compare
All of the points ☝️ should now be fixed. |
Leaving the default as in the corresponding Brian2 example
I made a few more changes @mstimberg , cleaning up the example scripts. Relevant for us:
|
You are done here @mstimberg, right? I'll merge this. |
Yep. |
This "beautifies" the example plots. I did not modify the Brunel/Hakim example, but I guess we have plotting code for it somewhere?
Here are the plots as a result of running:
Note that I also fixed the difference in scaling of the STDP example with respect to
brian2cuda/tests/features/speed.py
(@denisalevi maybe have a look that I did this correctly).