Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicer example plots #277

Merged
merged 20 commits into from
Mar 30, 2022
Merged

Nicer example plots #277

merged 20 commits into from
Mar 30, 2022

Conversation

mstimberg
Copy link
Member

This "beautifies" the example plots. I did not modify the Brunel/Hakim example, but I guess we have plotting code for it somewhere?

Here are the plots as a result of running:

$ python cobahh.py --devicename cpp_standalone --scenario uncoupled --N 5000 --monitors --no-profiling
$ python stdp.py --devicename cpp_standalone --delays none --no-profiling --monitors
$ python mushroombody.py --devicename cpp_standalone --N 10000 --no-profiling --monitors

Note that I also fixed the difference in scaling of the STDP example with respect to brian2cuda/tests/features/speed.py (@denisalevi maybe have a look that I did this correctly).

cobahh_cpp_scenario-uncoupled_N-5000_no-profiling_monitors_no-single-precision_atomics_bundle-mode_vuvuzela

stdp_cpp_delays-none_post-effects_N-10000_no-profiling_monitors_single-precision_atomics_bundle-mode_vuvuzela

mushroombody_cpp_N-10000_no-profiling_monitors_no-single-precision_atomics_bundle-mode_vuvuzela

@denisalevi denisalevi changed the base branch from master to paper2022-revision March 28, 2022 10:31
@denisalevi denisalevi changed the base branch from paper2022-revision to master March 28, 2022 10:32
@denisalevi
Copy link
Member

Thanks @mstimberg, looks great!

  1. Could you base any changes on the paper2022-revision branch? Because master already moved forward with changes that should not belong into the paper code (e.g. changing the code slots, which currently would break the benchmarks). Could you reapply your commits on paper2022-revision instead?
  2. I will check the STDP example again. But why is it running for 20s? Shouldn't we just run it for 10s and mention that the weight distribution is bimodal after ~100s?
  3. The plotting code for the Brunel/Hakim example that I used for figure 1 is here. But I guess we don't need it in the supps since its already in figure 1, right?

@mstimberg
Copy link
Member Author

  1. Could you base any changes on the paper2022-revision branch? Because master already moved forward with changes that should not belong into the paper code (e.g. changing the code slots, which currently would break the benchmarks). Could you reapply your commits on paper2022-revision instead?

Sure, will do.

2. I will check the STDP example again. But why is it running for 20s? Shouldn't we just run it for 10s and mention that the weight distribution is bimodal after ~100s?

It was a bit of a compromise to see the weight distribution changing in the last plot, but happy to run it for 10s (maybe making the runtime a command line argument?)

3. The plotting code for the Brunel/Hakim example that I used for figure 1 is here. But I guess we don't need it in the supps since its already in figure 1, right?

I agree, but for consistency it would be nice if the same (or at least a similar) plot gets generated when you run brunelhakim.py in the examples.

@mstimberg mstimberg changed the base branch from master to paper2022-revision March 28, 2022 11:23
@mstimberg
Copy link
Member Author

All of the points ☝️ should now be fixed.

@denisalevi
Copy link
Member

I made a few more changes @mstimberg , cleaning up the example scripts.

Relevant for us:

  • I changed the runtime to be the runtime from the examples in Brian2, that means whatever makes sense for the examples (even if that is not what we used in the benchmarks). That is because these scripts are meant for users, not for reviewers. The runtime can be set for all scripts now via --runtime as you already implemented for the STDP benchmark.
  • I changed the name for the partitioning parameter, so it can be recognized by reviewers.

examples/brunelhakim.py Outdated Show resolved Hide resolved
@denisalevi
Copy link
Member

You are done here @mstimberg, right? I'll merge this.

@denisalevi denisalevi merged commit 9bfb1d4 into paper2022-revision Mar 30, 2022
@denisalevi denisalevi deleted the example_plots branch March 30, 2022 11:37
@mstimberg
Copy link
Member Author

You are done here @mstimberg, right? I'll merge this.

Yep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants