Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing shebang #204

Merged
merged 1 commit into from
Apr 18, 2021
Merged

Changing shebang #204

merged 1 commit into from
Apr 18, 2021

Conversation

SudeshnaBora
Copy link
Contributor

Not sure if I need to create a pull request to this or a forked repository.

@SudeshnaBora SudeshnaBora self-assigned this Apr 18, 2021
@denisalevi
Copy link
Member

denisalevi commented Apr 18, 2021

Yes, this is fine. You have writing access to this repository (because we are member of the brian2cuda team). This means you are allowed to directly push to this repository. You could even push to the master branch without a PR. But let's not do that and instead create PRs (as you did here). This way both of us are informed about changes and can review changes if necessary.

If you wouldn't have write access and wanted to contribute, you would have to fork the repository (thereby ceating a copy where you have write access), then push there and open a PR from your fork to this repository, which someone with write access would then have to approve.

Having said that, if you make a small change like here (which we also discussed before), or if you don't think I need to review it, feel free to merge it yourself. Since you have write access, you are allowed to merge PRs. But if you want review, just tag me as you did and I'll review of course :)

So, yeah, fine to merge from my side. 😀

Copy link
Member

@denisalevi denisalevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge.

@denisalevi denisalevi merged commit 36ba984 into master Apr 18, 2021
@SudeshnaBora SudeshnaBora deleted the changingShebang branch April 21, 2021 15:57
denisalevi added a commit that referenced this pull request Jun 10, 2021
Changing shebang to use `bash` instead of `sh` in remote scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants