Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binomial implementation #178

Merged
merged 42 commits into from
Aug 19, 2020
Merged

Binomial implementation #178

merged 42 commits into from
Aug 19, 2020

Conversation

denisalevi
Copy link
Member

@denisalevi denisalevi commented Aug 19, 2020 •
edited
Loading

This PR does multiple things:

  • Binomial function implementation for cuda_standalone
  • Refactoring of device side RNG buffer (into class structure)
  • Fix RNG bugs for multiple run calls
  • Implement and test Brian's seed setting mechanism

This solves part of #47 .

@denisalevi
Implement Binomial function CUDAStandaloneDevice
ee814bc 
- Needs testing: brian2 test suite, brian2 seed mechanism
- How is the performance for using device side curand calls?
@denisalevi
Add missing binomial.py
6a7132a
@denisalevi
Fix declaration error when seed is set multiple times
b452e1d
@denisalevi
Add error checking for cuRAND calls
9383b06
@denisalevi
Refactor random number generation into class structur
4f2755c 
Working on #85, WIP, currently error with `cudaFree` call
@denisalevi
Adapt test suite scripts
6c848c9
@denisalevi
Fix multiple cudaFree error for multiple set_seed calls
2603376
@denisalevi
Fix random number test
f8220bd
@denisalevi
Clean up debug prints
b787f1a
@denisalevi
Move curand dev folder
bc2dcff
@denisalevi
Fix bugs in rand.cu
89952f9
@denisalevi
Adapt random number tests
78537d2
@denisalevi
Move section in network_run
9257527 
This way the part copied from CPPStandaloneDevice stays unmodified
@denisalevi
Implement random generation only for objects of current run, WIP
c981677 
Implements _i suffixes for random number buffer classes and instances.
Maybe not optimal, probably changing to single RandomNumberBuffer class
that takes care of it.
@denisalevi
RandomNumberBuffer now separates RNG for different runs
dfb6ceb 
RNG for codeobject run only once is broken currently
@denisalevi
Fix RNG for codeobjects run only once
0adafda 
Also refactor some code for reusing the rng test for codeobjects running
every tick and only once.
@denisalevi
Finish random number generation fix and clean up
f6fa36a
@denisalevi
Fix declaration error in rng
a33b77b
@denisalevi
Fix print message in test suite script
7fa5c20
@denisalevi
Update theoretical occupancy if ressources limit num_threads
921f7f1
@denisalevi
Fix not updated RNG state in binomial function
15ece7b
@denisalevi
Fix format specifier in printf strings
566294a
@denisalevi
Use as many curandStates as maximum number of threads used
36fe902 
Instead of one state per thread per kernel in one time step
@denisalevi
Make CurandBuffers in synapses create template file global variables
00aa50d 
Needed for host binomial implementations to have access to them.
@denisalevi
Replace string replacement with regex substitution for rand/randn code
834bd8c 
Closes #70
@denisalevi
Add tests for rand/randn regex substitution
3219c7f
@denisalevi
Add clusterbot support to test suite scripts
8561ef5
@denisalevi
Implement test suite script for remote grid engine qsub
4967965
@denisalevi
Fix test suite timer
d0b2b79
@denisalevi
Fix typo log dir
041117b
@denisalevi
Clean up test suite scripts
561bb72
@denisalevi
Fix binomial RNG for host and device code, WIP
0c96458 
Uncommited changes before 6 months dev break...
@denisalevi
Hard code GPU sm for selene and cluster
7ea25f0
@denisalevi
Set default compute capibility to sm_61
d424f17
@denisalevi
Init correct number of curand states for binomials
1691f2b 
Important for binomial in synapses, were N is only known after synapse
generation. Adds function to check for enough curand states before
running a codeobject with binomial function.
@denisalevi
Fix bug in setting curand seed
3251c62 
Pointer typo, the pointer adress was used as seed which didn't change.
@denisalevi
Fix example code path
711659f
@denisalevi
Fix tool utils to work with new sm_61 default
f44b4ad
@denisalevi
Finish binomial function implementation
4ea95d2 
- Initialize curand states before network run when they are used in
  synapse connect conditions
- Write test for different rand/randn and binomial function situation
  (host/device, buffer/on the fly)
@denisalevi
Add .log extention to test-suite logs
85b9a70
@denisalevi
Add tests for rand, randn, binomial occurence counting
8199852
@denisalevi
Adapt single run test suite script
f3ae8b6
@denisalevi denisalevi merged commit f7d3bef into master Aug 19, 2020
@denisalevi denisalevi deleted the binomial_implementation branch August 19, 2020 14:11
This was referenced Aug 22, 2020
Closed
Closed
denisalevi added a commit that referenced this pull request Jun 10, 2021
@denisalevi
Merge pull request #178 from brian-team/binomial_implementation
d88c3a1 
Binomial implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@denisalevi