Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error messages when PY_PYTHON* is malformed #114

Merged
merged 6 commits into from
Jun 18, 2021

Conversation

brettcannon
Copy link
Owner

@brettcannon brettcannon commented Jun 13, 2021

Closes #108

For PY_PYTHON3="3.8.10" without PYLAUNCH_DEBUG:

Error parsing '8.10' as an integer: invalid digit found in string

With PYLAUNCH_DEBUG:

Checking the PY_PYTHON3 environment variable
PY_PYTHON3 = '3.8.10'
Error parsing '8.10' as an integer: invalid digit found in string

@brettcannon brettcannon reopened this Jun 14, 2021
@brettcannon
Copy link
Owner Author

The coverage failures are false-positives.

Repository owner deleted a comment from codecov bot Jun 14, 2021
@jefftriplett
Copy link

Would this show up in verbose (-v) mode too?

@brettcannon
Copy link
Owner Author

Would this show up in verbose (-v) mode too?

No, that's passed directly to Python and I don't want to inject the Python Launcher into that as people parse that output.

@jefftriplett
Copy link

That makes sense. I guess I rarely if ever run python -v. I think the error message is much clearer about what is going on. It's much easier to solve a problem when it's obvious why something is failing. 👍🏼

@brettcannon brettcannon merged commit ace448e into main Jun 18, 2021
@brettcannon brettcannon deleted the better-env-var-error-message branch June 18, 2021 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure that setting PY_PYTHON to an invalid value is somehow discoverable
2 participants