Fix Rc #5
Merged
Fix Rc #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstadick
commented
May 1, 2023
| b: &Rc<&P>, | ||
| chromosome_order: &'a HashMap<String, usize>, | ||
| ) -> bool { | ||
| fn lt<'a, P: Positioned>(a: Rc<P>, b: Rc<P>, chromosome_order: &'a HashMap<String, usize>) -> bool { |
There was a problem hiding this comment.
this is a bit debatable. I think you could pass in borrows here as it's just a help function instead of having to increment the reference counter... but the uniformity of accepting an Rc is appealing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the hurdle here is that you were trying to wrap references with
Rc.Rcshould replace the&borrows. BasicallyRcis likeBoxin that it moves the object to the heap, and unlike box it creates a reference counter. To increment that reference counter you.clone()theRc. So, usingRcshould mean that you can effectively drop all lifetimes around the borrow that you are replaceing withRc.https://doc.rust-lang.org/std/rc/index.html