Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Build Error on Ubuntu/Debian with abp-filter-parser-cpp #214

Closed
groksrc opened this issue Jan 21, 2016 · 53 comments
Closed

Build Error on Ubuntu/Debian with abp-filter-parser-cpp #214

groksrc opened this issue Jan 21, 2016 · 53 comments

Comments

@groksrc
Copy link

groksrc commented Jan 21, 2016

I'm getting the following git permission error when trying to sudo npm install from tag v0.7.7. Looks like you may just need to open it up?

npm ERR! Linux 4.2.0-23-generic
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install"
npm ERR! node v5.4.1
npm ERR! npm  v3.3.12
npm ERR! code 128

npm ERR! Command failed: git clone --template=/home/groksrc/.npm/_git-remotes/_templates --mirror ssh:https://[email protected]/jariz/vibrant.js.git /home/groksrc/.npm/_git-remotes/git-ssh-git-github-com-jariz-vibrant-js-git-1-0-c8a459e7eb70fe4d97bee6c283479dcc
npm ERR! Cloning into bare repository '/home/groksrc/.npm/_git-remotes/git-ssh-git-github-com-jariz-vibrant-js-git-1-0-c8a459e7eb70fe4d97bee6c283479dcc'...
npm ERR! Permission denied (publickey).
npm ERR! fatal: Could not read from remote repository.
npm ERR! 
npm ERR! Please make sure you have the correct access rights
npm ERR! and the repository exists.
npm ERR! 
npm ERR! 
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     /home/groksrc/browser-laptop/npm-debug.log
@groksrc
Copy link
Author

groksrc commented Jan 21, 2016

I'm getting a different build error on master. Same command: sudo npm install

groksrc@ubuntu:~/browser-laptop$ git checkout master
Previous HEAD position was 97fabb8... 0.7.7
Switched to branch 'master'
Your branch is up-to-date with 'origin/master'.
groksrc@ubuntu:~/browser-laptop$ sudo npm install
npm WARN deprecated [email protected]: Deprecated.
npm WARN install Couldn't install optional dependency: Unsupported
npm WARN deprecated [email protected]: lodash@<2.0.0 is no longer maintained. Upgrade to lodash@^3.0.0
npm WARN install Couldn't install optional dependency: Unsupported
npm WARN lifecycle [email protected]~preinstall: cannot run in wd %s %s (wd=%s) [email protected] npm install bloom-filter-cpp && npm install hashset-cpp /home/groksrc/browser-laptop/node_modules/.staging/abp-filter-parser-cpp-fcb2148f0d7202dc35370a215a46cf7e
npm WARN lifecycle [email protected]~preinstall: cannot run in wd %s %s (wd=%s) [email protected] npm install hashset-cpp && npm install cppunitlite /home/groksrc/browser-laptop/node_modules/.staging/tracking-protection-a18e9ec093409a79dedc6595d5bb61cd
npm WARN prefer global [email protected] should be installed with -g
npm WARN prefer global [email protected] should be installed with -g

> [email protected] install /home/groksrc/browser-laptop/node_modules/cppunitlite
> node-gyp rebuild

make: Entering directory '/home/groksrc/browser-laptop/node_modules/cppunitlite/build'
  CXX(target) Release/obj.target/CppUnitLite/src/Failure.o
  CXX(target) Release/obj.target/CppUnitLite/src/SimpleString.o
  CXX(target) Release/obj.target/CppUnitLite/src/Test.o
  CXX(target) Release/obj.target/CppUnitLite/src/TestResult.o
  CXX(target) Release/obj.target/CppUnitLite/src/TestRegistry.o
  AR(target) Release/obj.target/CppUnitLite.a
  COPY Release/CppUnitLite.a
  CXX(target) Release/obj.target/test/test/StackMain.o
  CXX(target) Release/obj.target/test/test/StackTest.o
  LINK(target) Release/test
make: Leaving directory '/home/groksrc/browser-laptop/node_modules/cppunitlite/build'

> [email protected] install /home/groksrc/browser-laptop/node_modules/hashset-cpp
> node-gyp rebuild

make: Entering directory '/home/groksrc/browser-laptop/node_modules/hashset-cpp/build'
  CXX(target) Release/obj.target/hashset-cpp/addon.o
  CXX(target) Release/obj.target/hashset-cpp/HashSetWrap.o
  CXX(target) Release/obj.target/hashset-cpp/HashSet.o
  SOLINK_MODULE(target) Release/obj.target/hashset-cpp.node
  COPY Release/hashset-cpp.node
make: Leaving directory '/home/groksrc/browser-laptop/node_modules/hashset-cpp/build'

> [email protected] install /home/groksrc/browser-laptop/node_modules/nslog
> node-gyp rebuild

make: Entering directory '/home/groksrc/browser-laptop/node_modules/nslog/build'
  CXX(target) Release/obj.target/nslog/src/main.o
  CXX(target) Release/obj.target/nslog/src/nslog_linux.o
  SOLINK_MODULE(target) Release/obj.target/nslog.node
  COPY Release/nslog.node
make: Leaving directory '/home/groksrc/browser-laptop/node_modules/nslog/build'

> [email protected] install /home/groksrc/browser-laptop/node_modules/bloom-filter-cpp
> node-gyp rebuild

make: Entering directory '/home/groksrc/browser-laptop/node_modules/bloom-filter-cpp/build'
  CXX(target) Release/obj.target/bloom-filter-cpp/addon.o
  CXX(target) Release/obj.target/bloom-filter-cpp/BloomFilterWrap.o
  CXX(target) Release/obj.target/bloom-filter-cpp/BloomFilter.o
  SOLINK_MODULE(target) Release/obj.target/bloom-filter-cpp.node
  COPY Release/bloom-filter-cpp.node
make: Leaving directory '/home/groksrc/browser-laptop/node_modules/bloom-filter-cpp/build'

> [email protected] install /home/groksrc/browser-laptop/node_modules/electron-chromedriver
> node ./download-chromedriver.js


> [email protected] install /home/groksrc/browser-laptop/node_modules/pre-commit
> node install.js


> [email protected] install /home/groksrc/browser-laptop/node_modules/abp-filter-parser-cpp
> node-gyp rebuild

make: Entering directory '/home/groksrc/browser-laptop/node_modules/abp-filter-parser-cpp/build'
  CXX(target) Release/obj.target/abp-filter-parser-cpp/addon.o
In file included from ../ABPFilterParser.h:9:0,
                 from ../ABPFilterParserWrap.h:12,
                 from ../addon.cpp:7:
.././filter.h:12:25: fatal error: BloomFilter.h: No such file or directory
compilation terminated.
abp-filter-parser-cpp.target.mk:102: recipe for target 'Release/obj.target/abp-filter-parser-cpp/addon.o' failed
make: *** [Release/obj.target/abp-filter-parser-cpp/addon.o] Error 1
make: Leaving directory '/home/groksrc/browser-laptop/node_modules/abp-filter-parser-cpp/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:270:23)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Linux 4.2.0-23-generic
gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/groksrc/browser-laptop/node_modules/abp-filter-parser-cpp
gyp ERR! node -v v5.4.1
gyp ERR! node-gyp -v v3.0.3
gyp ERR! not ok 
... <Long list of installed modules truncated here> ...
npm ERR! Linux 4.2.0-23-generic
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install"
npm ERR! node v5.4.1
npm ERR! npm  v3.3.12
npm ERR! code ELIFECYCLE

npm ERR! [email protected] install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the abp-filter-parser-cpp package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls abp-filter-parser-cpp
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/groksrc/browser-laptop/npm-debug.log

@asiminiceanu
Copy link

I am getting other errors mostly because of node command usage on Debian:

make: *** [Release/obj.target/hashset-cpp/addon.o] Error 1
make: Leaving directory `/home/asiminiceanu/git/browser-laptop/node_modules/tracking-protection/node_modules/hashset-cpp/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/share/node-gyp/lib/build.js:267:23)
gyp ERR! stack     at ChildProcess.EventEmitter.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:797:12)
gyp ERR! System Linux 3.13.0-37-generic
gyp ERR! command "nodejs" "/usr/bin/node-gyp" "rebuild"
gyp ERR! cwd /home/asiminiceanu/git/browser-laptop/node_modules/tracking-protection/node_modules/hashset-cpp
gyp ERR! node -v v0.10.25
gyp ERR! node-gyp -v v0.10.10
gyp ERR! not ok 
npm WARN This failure might be due to the use of legacy binary "node"
npm WARN For further explanations, please read
/usr/share/doc/nodejs/README.Debian
nodejs command
--------------

The upstream name for the Node.js interpreter command is "node".
In Debian the interpreter command has been changed to "nodejs".

This was done to prevent a namespace collision: other commands use
the same name in their upstreams, such as ax25-node from the "node"
package.

@bbondy
Copy link
Member

bbondy commented Jan 21, 2016

I think the first error for the tag can go away if you setup ssh github access.
This is fixed already on master though.

For the other error please try updating to node-gyp v3.2.1

@asiminiceanu
Copy link

There are many errors like that. I just listed one. I can list the full output if you want.

@petitgrizzlies
Copy link

Same problem as asiminiceanu but with Fedora 23.
node-gyp isn't availible on fedora repo for me.
Is there an other way to solve it?

thanks

(i can join my npm-debug-log file)

@bkardell
Copy link
Contributor

I'm also getting the error below but it is on OSX 10.9.2... I'd delete and move this elsewhere, but I made the comment before I noticed it's about ubuntu/linux and it doesn't look like I can delete a comment.

../././filter.h:12:10: fatal error: 'BloomFilter.h' file not found
#include "BloomFilter.h"
^
1 error generated.
make: *** [Release/obj.target/abp-filter-parser-cpp/addon.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:270:23)
gyp ERR! stack at emitTwo (events.js:100:13)
gyp ERR! stack at ChildProcess.emit (events.js:185:7)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Darwin 13.1.0
gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/bkardell/projects/browser-laptop/node_modules/abp-filter-parser-cpp
gyp ERR! node -v v5.5.0
gyp ERR! node-gyp -v v3.0.3
gyp ERR! not ok
npm ERR! Darwin 13.1.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "--save" "abp-filter-parser-cpp"
npm ERR! node v5.5.0
npm ERR! npm v3.3.12
npm ERR! code ELIFECYCLE

npm ERR! [email protected] install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the abp-filter-parser-cpp package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! node-gyp rebuild
npm ERR! You can get their info via:
npm ERR! npm owner ls abp-filter-parser-cpp
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR! /Users/bkardell/projects/browser-laptop/npm-debug.log

@UndarkAido
Copy link

The version of nodejs in Ubuntu's repositories is too old.
I installed nodejs from here: https://nodejs.org/en/download/package-manager/ and now it seems to work.

Edit: No, that wasn't the entire problem.

@groksrc
Copy link
Author

groksrc commented Jan 21, 2016

I am running node-gyp v3.2.1. Also, I can clone and compile abp-filter-parser-cpp on it's own from source here: https://github.com/bbondy/abp-filter-parser-cpp.git

@bgiesing
Copy link

I am having a similar issue on OpenSuse Leap 42:

26653 silly lifecycle [email protected]~preinstall: Returned: code: 1  signal: null
26654 info lifecycle [email protected]~preinstall: Failed to exec preinstall script
26655 verbose lifecycle [email protected]~preinstall: unsafe-perm in lifecycle true
26656 verbose lifecycle [email protected]~preinstall: PATH: /usr/lib64/node_modules/npm/bin/node-gyp-bin:/home/bgiesing/projects/browser-laptop/node_modules/.staging/tracking-protection-aded2df7f2d4096bf8666c0af5400abe/node_modules/.bin:/home/bgiesing/projects/browser-laptop/node_modules/.bin:/home/bgiesing/bin:/usr/local/bin:/usr/bin:/bin:/usr/bin/X11:/usr/games
26657 verbose lifecycle [email protected]~preinstall: CWD: /home/bgiesing/projects/browser-laptop/node_modules/.staging/tracking-protection-aded2df7f2d4096bf8666c0af5400abe
26658 silly lifecycle [email protected]~preinstall: Args: [ '-c', 'npm install hashset-cpp && npm install cppunitlite' ]
26659 silly lifecycle [email protected]~preinstall: Returned: code: 1  signal: null
26660 info lifecycle [email protected]~preinstall: Failed to exec preinstall script
26661 verbose unlock done using /home/bgiesing/.npm/_locks/staging-91ddc4e934d9d29b.lock for /home/bgiesing/projects/browser-laptop/node_modules/.staging
26662 silly rollbackFailedOptional Starting
26663 silly rollbackFailedOptional Finishing
26664 silly runTopLevelLifecycles Starting
26665 silly runTopLevelLifecycles Finishing
26666 silly install printInstalled
26667 verbose stack Error: [email protected] preinstall: `npm install bloom-filter-cpp && npm install hashset-cpp`
26667 verbose stack Exit status 1
26667 verbose stack     at EventEmitter.<anonymous> (/usr/lib64/node_modules/npm/lib/utils/lifecycle.js:232:16)
26667 verbose stack     at emitTwo (events.js:87:13)
26667 verbose stack     at EventEmitter.emit (events.js:172:7)
26667 verbose stack     at ChildProcess.<anonymous> (/usr/lib64/node_modules/npm/lib/utils/spawn.js:24:14)
26667 verbose stack     at emitTwo (events.js:87:13)
26667 verbose stack     at ChildProcess.emit (events.js:172:7)
26667 verbose stack     at maybeClose (internal/child_process.js:821:16)
26667 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
26668 verbose pkgid [email protected]
26669 verbose cwd /home/bgiesing/projects/browser-laptop
26670 error Linux 4.1.13-5-default
26671 error argv "/usr/bin/node" "/usr/bin/npm" "install"
26672 error node v5.4.1
26673 error npm  v3.3.12
26674 error code ELIFECYCLE
26675 error [email protected] preinstall: `npm install bloom-filter-cpp && npm install hashset-cpp`
26675 error Exit status 1
26676 error Failed at the [email protected] preinstall script 'npm install bloom-filter-cpp && npm install hashset-cpp'.
26676 error Make sure you have the latest version of node.js and npm installed.
26676 error If you do, this is most likely a problem with the abp-filter-parser-cpp package,
26676 error not with npm itself.
26676 error Tell the author that this fails on your system:
26676 error     npm install bloom-filter-cpp && npm install hashset-cpp
26676 error You can get their info via:
26676 error     npm owner ls abp-filter-parser-cpp
26676 error There is likely additional logging output above.
26677 verbose exit [ 1, true ]

@diracdeltas
Copy link
Member

I too am seeing the error with abp-filter-parser-cpp on debian sid. node-gyp is 3.2.1 so that isn't the issue

@diracdeltas
Copy link
Member

in #237, sid says that updating to node 5.5 fixed it. i am Away-From-Linux-Keyboard right now, but curious if that works for others.

@bkardell
Copy link
Contributor

@diracdeltas I was still getting that with node 5.5 yesterday, but I had a host of other problems. I wound up basically removing all of my node modules & libs (things installed with -g and so on), making sure I chowned it all (I think something at some point must've been run with sudo) and various other hiccups, but ultimately I did get it working last night and ... <3 <3. I did open another issue about configuable ports - I have too many other things that all want 8080

@diracdeltas diracdeltas changed the title Build Error on Ubuntu 15.04 Build Error on Ubuntu/Debian with abp-filter-parser-cpp Jan 22, 2016
@Chaasof
Copy link

Chaasof commented Jan 23, 2016

I have nodejs v5.5, npm v3.5.3 and node-gyp v3.2.1 and I can't finish the npm install :s https://pastebin.mozilla.org/8857451 any solution ?
Thanks

@Adejair
Copy link
Contributor

Adejair commented Jan 24, 2016

@diracdeltas @bbondy I have the same problem to build brave on Ubuntu, I tried build with differents version of NPM and NODE, I using version V5.5.0 on NODE and V3.5.3 in NPM.

@diracdeltas
Copy link
Member

I fixed this for me on Debian unstable by deleting node_modules, updating to node 5.5, and then doing npm install again!

@bbondy
Copy link
Member

bbondy commented Jan 24, 2016

I was also independently verifying the same steps on Ubuntu 14.04.1 x86_64 and it works with a cleared node_modules directory:

node-gyp v3.2.1
node 5.5.0
npm 3.3.12

@ghost
Copy link

ghost commented Jan 24, 2016

I was able to solve this, using:

sudo npm install --unsafe-perm

@Adejair
Copy link
Contributor

Adejair commented Jan 24, 2016

@Saynt Thanks, Its work with me.

bkardell pushed a commit to bkardell/browser-laptop that referenced this issue Jan 24, 2016
@bgiesing
Copy link

So now I get this error on OpenSUSE Leap with node 5.5, the latest npm/node-gyp, and using @Saynt's unsafe-perms suggestion:

EDIT: Nevermind, forgot to install base devel packages! Stupid me!

@digitalcrafted
Copy link

@Saynt Thanks!

@SphinxKnight
Copy link

Confirming that upgrading npm/node fixes the issue for Fedora 23 as well.

@smcnally
Copy link

On Ubuntu 15.04, built Node 5.5 per these instructions

Was able to build "successfully." Can run server and tests; running browser fails with "electron: not found." Searching through log other tickets to address same.

@shahbaz17
Copy link

Hello @Saynt
i followed your suggested step but received this error. Can anyone help me?

npm ERR! Linux 3.19.0-47-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "install" "--unsafe-perm"
npm ERR! node v5.5.0
npm ERR! npm v3.3.12
npm ERR! path /home/shahbaz17/git/browser-laptop/node_modules/extract-zip/node_modules/mkdirp/bin/cmd.js
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall chmod

npm ERR! enoent ENOENT: no such file or directory, chmod '/home/shahbaz17/git/browser-laptop/node_modules/extract-zip/node_modules/mkdirp/bin/cmd.js'
npm ERR! enoent This is most likely not a problem with npm itself
npm ERR! enoent and is related to npm not being able to find a file.
npm ERR! enoent

npm ERR! Please include the following file with any support request:
npm ERR! /home/shahbaz17/git/browser-laptop/npm-debug.log

@diracdeltas
Copy link
Member

@PunkUnity you can do a clean install by rm -rf node_modules/, then doing npm install again. Feel free to comment on #249; we welcome pull requests for linux packaging!

@nujabse
Copy link

nujabse commented Jan 27, 2016

@diracdeltas

rm -rf node_modules/, then doing npm install again

that works perfect for me on archlinux! Thanks!

@ghost
Copy link

ghost commented Jan 27, 2016

@shahbaz17 maybe try this: nodejs/node#2814

@sroerick
Copy link

I'm still having this issue.
Linux Mint 17.1
node v5.5.0
npm v3.3.12
node-gyp is installed
I removed the node files.

Still getting the

npm ERR! Failed at the [email protected] install script 'node-gyp rebuild'.

error

@shahbaz17
Copy link

@Saynt not working after following nodejs/node#2814

@jmcastellote
Copy link

Very Similar error here.

  • Using:
    Debian Jessie with regular Main & Contrib repo packages
    nodejs v5.5.0
    npm v3.3.12
    node-gyp v3.2.1
  • I get, after npm install:
    npm ERR! [email protected] install: 'node-gyp rebuild'
    Looking deeper, I see that file "BloomFilter.h" is missing from Brave's module "abp-filter-parser-cpp". As this module is self-managed by brave, I cannot replace it with the latest build in github.
  • I have tried, from previous comments (much appreciated, btw):
    · Removing content of 'browser-laptop/node_modules' after first fail.
    · installing with --unsafe-perms
    · installing with -g
    · installing with both options

-g gives even more strange results. The rest always fails with above error

@elsehow
Copy link

elsehow commented Jan 29, 2016

installing with --unsafe-perms fixes this issue for me. @jmcastellote do you have bulid-essential installed?

@rob-blasetti
Copy link
Contributor

fixed:
.././filter.h:12:25: fatal error: BloomFilter.h: No such file or directory
on OSX El Capitan with sudo npm install --unsafe-perms

@sroerick
Copy link

@elsehow I have tried the same things @jmcastellote did, to no avail. --unsafe-perms, and -g. Both also fail.

And yes, build-essential is absolutely installed.

@jmcastellote
Copy link

@elsehow @rblasett thanks for double-checking. Yeah, build-essentials 11.7 installed, just like @sroerick .
Initially I was doing the whole install as root, so I tried with sudo and regular user as you guys show but same results.

@olgabot
Copy link

olgabot commented Feb 5, 2016

Similar issue with node-gyp not installing on Travis-CI (Ubutnu Linux)
https://travis-ci.org/biom262/biom262-2016/builds/107156450

@uD4ra
Copy link

uD4ra commented Feb 5, 2016

Same issue with node-gyp and installing with --unsafe-perms also with rm -rf node_modules/ npm install errors after tried with every one of this. (on Ubuntu Xenial)

@olgabot
Copy link

olgabot commented Feb 5, 2016

FYI I was able to fix it by adding an empty .npmignore file:

touch .npmignore

@olgabot
Copy link

olgabot commented Feb 5, 2016

I read somewhere that the .gitignore and .npmignore conflict somehow. Hope that helps someone!

@cezaraugusto
Copy link
Contributor

For people struggling with build errors on Ubuntu 14.02, running a clean install should solve it:

rm -rf node_modules/ and then npm install

@ashickurnoor
Copy link

I am getting the same error. Using OS X 10.10.5 (14F1605) .

npm version : 3.7.3

@nkolba
Copy link

nkolba commented Apr 29, 2016

Hi, trying to build on a Mac and having very similar problems. This is the error I'm getting:

4 errors generated.
make: *** [Release/obj.target/keytar/src/main.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/Users/nkolba/browser-laptop/node_modules/node-gyp/lib/build.js:276:23)
gyp ERR! stack at emitTwo (events.js:100:13)
gyp ERR! stack at ChildProcess.emit (events.js:185:7)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:204:12)
gyp ERR! System Darwin 14.5.0
gyp ERR! command "/Users/nkolba/.nvm/versions/node/v5.8.0/bin/node" "/Users/nkolba/browser-laptop/node_modules/.bin/node-gyp" "rebuild" "--target=0.37.7" "--arch=x64" "--dist-url=https://atom.io/download/atom-shell"
gyp ERR! cwd /Users/nkolba/browser-laptop/node_modules/keytar
gyp ERR! node -v v5.8.0
gyp ERR! node-gyp -v v3.3.1
gyp ERR! not ok

I've tried node v 5.5 as well - clearing node-modules each time and doing a full import.
npm version is 3.7.3

I was on node-gyp 3.2.1 previously - upgraded and now can't seem to get back - don't know if that's impacting anything.

also tried doing npm install with --unsafe-perms - no luck there.

Any help would be greatly appreciated! thanks

@nkolba
Copy link

nkolba commented Apr 30, 2016

I found this issue, which was the root problem: #807

I was able to get Brave to build using the fix with NPM link, but was not able to run it - found hacking it with global install of abp-parser-filter-cpp allowed me to run (woohoo!) but obviously not a good long term solution - so still interested to find out what is wrong in my environment that I can't use the abp-filter-parser from npm...

@luixxiul
Copy link
Contributor

luixxiul commented May 4, 2016

Setting up node -v 5.5.0 node-gyp -v 3.2.1 on Ubuntu 14.04.01 x86_64 (same as #214 (comment)) and sudo npm i,

> [email protected] install /home/test/browser-laptop/node_modules/abp-filter-parser-cpp
> node-gyp rebuild

make: Entering directory `/home/test/browser-laptop/node_modules/abp-filter-parser-cpp/build'
  CXX(target) Release/obj.target/abp-filter-parser-cpp/addon.o
In file included from ../ABPFilterParser.h:9:0,
                 from ../ABPFilterParserWrap.h:12,
                 from ../addon.cpp:7:
.././filter.h:12:25: fatal error: BloomFilter.h: No such file or directory
 #include "BloomFilter.h"
                         ^
compilation terminated.
make: *** [Release/obj.target/abp-filter-parser-cpp/addon.o] Error 1
make: Leaving directory `/home/test/browser-laptop/node_modules/abp-filter-parser-cpp/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:270:23)
gyp ERR! stack     at emitTwo (events.js:100:13)
gyp ERR! stack     at ChildProcess.emit (events.js:185:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Linux 3.13.0-32-generic
gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/test/browser-laptop/node_modules/abp-filter-parser-cpp
gyp ERR! node -v v5.5.0
gyp ERR! node-gyp -v v3.0.3
gyp ERR! not ok

fatal error: BloomFilter.h: No such file or directory <- Isn't it the cause of the error?

@cezaraugusto
Copy link
Contributor

@luixxiul had you tried a clean npm install? I'm also using Ubuntu.

@luixxiul
Copy link
Contributor

luixxiul commented May 10, 2016

Finally succeeded. Not sure what was wrong at all (maybe due to the version of Node?).

The procedure that worked on Ubuntu 14.04.01 (clean install): https://gist.github.com/luixxiul/e294f2e5ef5bdf5ab6910d8224a9b7a9

Would someone confirm this works? If it does or does not, please tell me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests