Fix a bug with sqllite default values and inserts #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug where sequelize was incorrectly inserting a raw string when it should have been respecting the default defined at the database column level. This PR fixes it by reducing the
fields
that sequelize inserts to to only those defined on thevalues
.Here's a repro. Make a table like this:
And try to insert just a record with just a "name". You'll end up with the literal
strftime('%Y-%m-%dT%H:%M:%SZ')
for thecreated
column.