Use Sequelize BOOLEAN for boolean fields #31
Conversation
…ing create mutations to return id: null
const resolvers = {
Mutation: {
updateTimer: fn => async (obj, values, info) => {
doSomethingBefore()
const ret = await fn(obj, values, info)
doSomethingAfter()
return ret
}
}
}
createThings(input: [ThingCreateInput!]): [Thing] deleteThings(where: SequelizedJSON!): GenericResponse
…nd arg, like:
{
Mutation: {
updateTimer: fn => async (obj, values, info) => {
// something before
const ret = await fn(obj, values, info)
// something after
return ret
}
},
Query: {
now: {
type: GraphQLString,
resolve: () => new Date().toISOString()
}
}
}
There was a problem hiding this comment.
I'm reviewing this way late @renato – so no obligation to respond, but there appears to be more than the bool change in this PR and just curious what the goal of the customSchema stuff is so I can document it.
| @@ -37,7 +40,7 @@ export default columns => { | |||
| field: column.name, | |||
| allowNull: column.notnull === 0 || column.dflt_value !== null, | |||
| defaultValue: column.dflt_value, | |||
| autoIncrement: column.type === 'INTEGER' && column.pk === 1, | |||
| autoIncrement: column.type === 'integer' && column.pk === 1, | |||
There was a problem hiding this comment.
IIRC the case of this is not consistent, to be safe we should column.type.toLowerCase() perhaps?
There was a problem hiding this comment.
I ended up using a totally custom schema, but the idea of the customSchema was to extend the default types/resolvers with custom ones, I tried to give somes examples on the commit messages.
Looking at the commit dates I think only the first commit was actually intended to be part of the PR, sorry about that.
About the integer, I've changed to the case that worked for me at the time, I'm not sure it's inconsistent but it's possible.
SQLite boolean fields are currently being typed as Sequelize's NUMERIC type (https://github.com/bradleyboy/tuql/blob/master/src/builders/definitions.js#L22) but they end up as a String type on the GraphQL API.
I'm using Sequelize's BOOLEAN instead and it's working as expected.