Pin and test Poetry version #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poetry has introduced a number of problematic changes recently. To help buffer against these problematic changes, this commit will implement installation of specific versions of Poetry, rather than the latest version. - Move `POETRY_*` variables to workflow-level `env` to use in all jobs - Set `POETRY_HOME` to align GitHub Actions and Docker installations - Template `POETRY_VERSION` into the download URL - Run a shell test to assert that `poetry -V` matches `POETRY_VERSION`
Poetry has introduced a number of problematic changes recently. To help buffer against these problematic changes, this commit will implement installation of specific versions of Poetry, rather than the latest version. - Add `POETRY_VERSION` build argument and default to Dockerfile - Use `POETRY_VERSION` build argument when building Docker images - Run a shell test to assert that `poetry -V` matches `POETRY_VERSION`
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/br3ndonland/inboard/6K8iR1WpFETt7JDKFDaqrym4LApM |
Codecov Report
@@ Coverage Diff @@
## develop #44 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 264 264
=========================================
Hits 264 264
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
br3ndonland
added a commit
that referenced
this pull request
Sep 19, 2021
#36 #44 PR #44 introduced version tests for Poetry. The GitHub Actions workflow builds.yml was matching the version number as a substring anywhere in the output of `poetry -V`, but the hooks.yml and tests.yml workflows were matching the version number at the end of the `poetry -V` output. This would have become an issue if the format of the output was changed, and sure enough, Poetry 1.2.0 changes the format to have parentheses around the version number. This commit will update the hooks.yml and tests.yml workflows to match the version number as a substring anywhere in the output of `poetry -V`.
1 task
br3ndonland
added a commit
to br3ndonland/template-python
that referenced
this pull request
Oct 24, 2021
Merged
br3ndonland
added a commit
to br3ndonland/dotfiles
that referenced
this pull request
Oct 10, 2022
After creating numerous problems for maintainers by cramming breaking changes into patch releases, Poetry finally released a minor version, 1.2, which should probably have been a major version. In order to upgrade, each project will need to update its pyproject.toml (to support groups), update any references to the install script (which has been moved twice), and make several other associated changes. This commit will set an upper bound on the `pipx install poetry` command to avoid upgrading to Poetry 1.2. br3ndonland/inboard#36 br3ndonland/inboard#44 br3ndonland/inboard#47 https://python-poetry.org/blog/announcing-poetry-1.2.0/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Poetry has introduced a number of problematic changes recently. To help buffer against these problematic changes, this PR will implement installation and testing of specific versions of Poetry, rather than the latest version.
Changes
The following steps will be taken to verify the Poetry version, both when installing Poetry on the GitHub Actions runner, and when installing Poetry in Docker container images:
POETRY_VERSIONenvironment variable, which should be used by the get-poetry.py and install-poetry.py install scripts to install the specified versionPOETRY_VERSIONenvironment variable into the URLpoetry -Vcommand matchesPOETRY_VERSION(in case the install script stops correctly readingPOETRY_VERSION, for example)Commits:
Related
#36
python-poetry/poetry#3870
python-poetry/poetry#4210
python-poetry/poetry#4429