Drop Codecov #12
Merged
Drop Codecov #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/br3ndonland/fastenv/8pxpepQvUNjBR21AjmNmPeXfx9pE |
br3ndonland
force-pushed
the
drop-codecov
branch
from
754ff02
to
608aad9
Compare
br3ndonland
force-pushed
the
drop-codecov
branch
from
608aad9
to
4469724
Compare
br3ndonland
force-pushed
the
drop-codecov
branch
from
4469724
to
a62815d
Compare
pytest-cov was previously just measuring coverage of the source code. This commit will increase coverage so the tests can be included also. - Remove unused pytest fixture - add `# pragma: no cover` comments to `pytest.skip` statements - Update `tests/cloud/test_object_storage.py` to bring coverage to 100%
This commit will correct the two failing tests: ```text FAILED tests/cloud/test_object_storage.py::TestObjectStorageClientUnit:: test_generate_presigned_url_example[False] FAILED tests/cloud/test_object_storage.py::TestObjectStorageClientUnit:: test_generate_presigned_post_example[False] ``` The `False` parameter output means that `use_session_token` was `False` in the corresponding fixtures in conftest.py: - `object_storage_config_for_presigned_url_example` - `object_storage_config_for_presigned_post_example` There may be situations, such as tests in a GitHub Actions workflow, in which multiple sets of credentials are present. In these situations, there may be environment variables such as `AWS_SESSION_TOKEN` that are set, but should not be used in certain `ObjectStorageConfig` instances. Setting `session_token` to an empty string (`session_token=""`) prevents `class ObjectStorageConfig` from using the environment variable value. There is a unit test, `test_config_with_environment_variable_overrides` in `tests/cloud/test_object_storage.py`, which verifies the correct behavior. However, the pytest fixtures listed above were still setting `session_token=None`, which then was making their `ObjectStorageConfig` instances inadvertently pick up `AWS_SESSION_TOKEN`. The fix is just to set `session_token=""` when `use_session_token=False` in those fixtures.
br3ndonland
force-pushed
the
drop-codecov
branch
from
a62815d
to
5532293
Compare
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.17%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Codecov is a platform for displaying and tracking test coverage. Codecov's main value add is coverage delta (how a PR or commit will change coverage, compared with the previous result). Another minor value add is having the GitHub app comment on PRs.
However, Codecov doesn't actually measure test coverage. Other test coverage reporting tools, like coverage.py for Python projects, already do most of the work.
There are also some potential drawbacks to using Codecov:
For this project, the drawbacks of using Codecov outweigh the benefits, so Codecov will no longer be used. Test coverage reporting will be performed with coverage.py.
Changes
Related