Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with object storage (Sourcery refactored) #11

Closed
wants to merge 1 commit into from

Conversation

sourcery-ai[bot]
Copy link
Contributor

@sourcery-ai sourcery-ai bot commented Apr 9, 2022

Pull Request #8 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the object-storage branch, then run:

git fetch origin sourcery/object-storage
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from br3ndonland April 9, 2022 21:18
form_data_to_return = {**form_data_from_policy, **additional_form_data}
form_data_to_return = form_data_from_policy | additional_form_data
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function ObjectStorageClient._prepare_presigned_post_form_data refactored with the following changes:

return {**input_kwargs, **env_file_object_additional_input}
return input_kwargs | env_file_object_additional_input
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function env_file_object_expected_output refactored with the following changes:

@vercel
Copy link

vercel bot commented Apr 9, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/br3ndonland/fastenv/Ht9YeWqKhwPAfgZfhq5H9PZ5jyaA
✅ Preview: https://fastenv-git-sourcery-object-storage-br3ndonland.vercel.app

@sourcery-ai
Copy link
Contributor Author

sourcery-ai bot commented Apr 9, 2022

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 1.02 ⭐ 1.02 ⭐ 0.00
Method Length 36.34 ⭐ 36.34 ⭐ 0.00
Working memory 6.10 ⭐ 6.10 ⭐ 0.00
Quality 84.43% 84.43% 0.00%
Other metrics Before After Change
Lines 589 589 0
Changed files Quality Before Quality After Quality Change
tests/conftest.py 84.43% ⭐ 84.43% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@br3ndonland
Copy link
Owner

As explained in #9 and #10, the use-dictionary-union refactoring is not appropriate for this project. The dictionary union operator was introduced in Python 3.9. This project still supports Python 3.8. Attempting to use the union operator on Python 3.8 will result in errors, as seen in the failed mypy check on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant