Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text areas do not redraw themselves #30

Closed
saagarjha opened this issue Apr 12, 2017 · 6 comments · Fixed by #32 or #120
Closed

Text areas do not redraw themselves #30

saagarjha opened this issue Apr 12, 2017 · 6 comments · Fixed by #32 or #120

Comments

@saagarjha
Copy link
Contributor

I'm having an odd issue where the text areas are don't seem to update at all. I can "type" in them (I've confirmed that the relevant delegate methods are being called, and that their text is changing internally), but nothing shows up. Based on this:

screen shot 2017-04-12 at 16 09 15

which was caused by focusing the text field above it a bunch of times, I'm guessing that the text area isn't redrawing itself properly. Oddly enough, adding a new text view in the storyboard seems to fix the issue.
@keith
Copy link
Member

keith commented Apr 12, 2017

Interesting 🤔 let me look into this.

@saagarjha saagarjha changed the title Text areas are do not redraw themselves Text areas do not redraw themselves Apr 13, 2017
@funkenstrahlen
Copy link

I have the same problem. Title text field works though.

@keith
Copy link
Member

keith commented Apr 13, 2017

@Reflejo said he experienced this as well so I'm hoping he has a chance to debug it.

@jessesquires
Copy link
Contributor

Same here. I just played around with this. Looks like an issue with stack view and/or constraints?

I removed and re-added the description textView, then everything was working fine

@jessesquires
Copy link
Contributor

confirmed. issue with autolayout constraints. will submit a PR

@jessesquires jessesquires mentioned this issue Apr 14, 2017
Merged
@keith keith closed this as completed in #32 Apr 14, 2017
keith pushed a commit that referenced this issue Apr 14, 2017
Merge pull request #32 from jessesquires/master
90b3822 
Fix storyboard constraints so textViews are responsive, fixes #30
@keith
Copy link
Member

keith commented Apr 14, 2017

I've just pushed 0.1.1 with @jessesquires' fix. Please let me know if it doesn't fix this issue for you!

https://github.com/br1sk/brisk/releases/tag/0.1.1

@keith keith mentioned this issue Apr 14, 2017
Closed
saagarjha added a commit to saagarjha/brisk that referenced this issue Apr 15, 2017
@saagarjha
Alternate workaround for br1sk#30
87fd524 
Instead of a constant constraint, we can simply resize the window to get responsiveness back
Also:
* Updated CocoaPods
* Improved some ambigous constraints
saagarjha added a commit to saagarjha/brisk that referenced this issue Aug 24, 2017
@saagarjha
Hacky fix for br1sk#30, br1sk#33
75244ab
@saagarjha saagarjha mentioned this issue Aug 24, 2017
Merged
@openradar-mirror openradar-mirror mentioned this issue Aug 24, 2017
Open
saagarjha added a commit to saagarjha/brisk that referenced this issue Aug 24, 2017
@saagarjha
Hacky fix for br1sk#30, br1sk#33
b186b18
saagarjha added a commit to saagarjha/brisk that referenced this issue Aug 24, 2017
@saagarjha
Hacky fix for br1sk#30, br1sk#33
3faff48
@saagarjha saagarjha mentioned this issue Aug 25, 2017
Open
keith pushed a commit that referenced this issue Aug 26, 2017
Merge pull request #120 from saagarjha/master
129c482 
Workaround for #30, #33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@funkenstrahlen @keith @jessesquires @saagarjha