Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remove screenshot NullPointer test #898

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix remove screenshot NullPointer test #898

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a29fac9
fix test
montedonio-pinterest Dec 12, 2022
05895da
.
montedonio-pinterest Dec 12, 2022
8ffa84a
Revert "Redirect test output to file to reduce build log noise"
montedonio-pinterest Dec 13, 2022
2dc8aca
test logs
montedonio-pinterest Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix test
  • Loading branch information
@montedonio-pinterest
montedonio-pinterest committed Dec 12, 2022
commit a29fac98709139383391864dd34a2b2774dd15f3
3 changes: 3 additions & 0 deletions webapp/src/test/java/com/box/l10n/mojito/service/screenshot/ScreenshotServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ public void testDeleteScreenshot() throws Exception {
List<ThirdPartyScreenshot> createdThirdPartyScreenshots =
thirdPartyScreenshotRepository.findAllByScreenshotId(screenshot.getId());
Assert.assertEquals(createdThirdPartyScreenshots.get(0).getId(), thirdPartyScreenshot.getId());
screenshot.setThirdPartyScreenshots(new HashSet(createdThirdPartyScreenshots));

Repository repository = repositoryService.createRepository("testRepository");

Expand All @@ -105,7 +106,9 @@ public void testDeleteScreenshot() throws Exception {
ScreenshotTextUnit createdScreenshotTextUnit =
screenshotTextUnitRepository.findById(screenshotTextUnit.getId()).orElse(null);
assertEquals(createdScreenshotTextUnit.getScreenshot().getId(), screenshot.getId());
screenshot.setScreenshotTextUnits(new HashSet(Arrays.asList(createdScreenshotTextUnit)));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can use Sets.newHashSet() from Guava


screenshotRepository.save(screenshot);
screenshotService.deleteScreenshot(screenshot.getId());

verify(thirdPartyServiceMock, times(1))
Expand Down