Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly detect Firefox on iPad #379

Merged
merged 1 commit into from
Dec 26, 2019
Merged

Correctly detect Firefox on iPad #379

merged 1 commit into from
Dec 26, 2019

Conversation

neckro
Copy link
Contributor

@neckro neckro commented Dec 13, 2019

This one's a little tricky, since it pretends to be desktop Safari for some reason.

See issue #378.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 775

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 89.581%
Totals Coverage Status
Change from base Build 745: 0.03%
Covered Lines: 540
Relevant Lines: 557
💛 - Coveralls

lancedikson
lancedikson approved these changes Dec 26, 2019
View reviewed changes
Copy link
Collaborator

@lancedikson lancedikson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks and sorry for the delay. Will release soon!

@lancedikson lancedikson changed the base branch from production to master December 26, 2019 13:48
@lancedikson lancedikson merged commit de5b4e0 into bowser-js:master Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lancedikson lancedikson lancedikson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neckro @coveralls @lancedikson