Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting OctoPrint 1.10 and Python 3.12 #258

Merged
merged 17 commits into from
Apr 24, 2024
Merged

Supporting OctoPrint 1.10 and Python 3.12 #258

merged 17 commits into from
Apr 24, 2024

Conversation

RobinTail
Copy link
Collaborator

@RobinTail RobinTail commented Feb 12, 2024 •
edited
Loading

Preparing for the upcoming OctoPrint 1.10 having Python 3.12 support and testing the compatibility.

Instead of #233

@RobinTail RobinTail changed the title Support 1.10 Supporting OctoPrint 1.10 Feb 12, 2024
@coveralls
Copy link

coveralls commented Feb 12, 2024 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling 188c39a on support-1-10
into b023c8f on develop.

@RobinTail RobinTail added coverage Improving the tests dependencies labels Feb 12, 2024
@RobinTail
Copy link
Collaborator Author

That version should also enable Python 3.12 support

@RobinTail
Copy link
Collaborator Author

3.12 has a newer setuptools, which since version 66 does not like the unknown version produced by miniver.
Related issue: pypa/setuptools#3772

@RobinTail
Copy link
Collaborator Author

snapshottest is not compatible with Python 3.12 — related issue:
syrusakbary/snapshottest#166

@RobinTail RobinTail changed the title Supporting OctoPrint 1.10 Supporting OctoPrint 1.10 with Python 3.12 Feb 12, 2024
RobinTail
RobinTail commented Feb 12, 2024
View reviewed changes
.github/workflows/CI.yaml Outdated Show resolved Hide resolved
RobinTail
RobinTail commented Apr 3, 2024
View reviewed changes
.github/workflows/CI.yaml Outdated Show resolved Hide resolved
RobinTail
RobinTail commented Apr 8, 2024
View reviewed changes
.github/workflows/CI.yaml Outdated Show resolved Hide resolved
@RobinTail RobinTail marked this pull request as ready for review April 24, 2024 14:13
RobinTail
RobinTail commented Apr 24, 2024
View reviewed changes
Copy link
Collaborator Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@RobinTail RobinTail added the refactoring Better implementation of the same thing label Apr 24, 2024
@RobinTail RobinTail changed the title Supporting OctoPrint 1.10 with Python 3.12 Supporting OctoPrint 1.10 and Python 3.12 Apr 24, 2024
@RobinTail RobinTail merged commit 262fed5 into develop Apr 24, 2024
28 checks passed
@RobinTail RobinTail mentioned this pull request Apr 24, 2024
Merged
RobinTail added a commit that referenced this pull request Apr 24, 2024
@RobinTail
🚀 4.2.0, #265
6723ce2 
* UI: Upgrading all dependencies (#261)

* Upgrading all dependencies.

* Upgrading typescript eslint.

* Upgrading all dependencies. (#262)

* UI: upgrading all dependencies. (#264)

* Supporting OctoPrint 1.10 and Python 3.12 (#258)

* Testing on 1.10.x

* Using rc2.

* Including full version to the matrix.

* Adjusting exceptions.

* Removing condition on Wheel installation.

* Testing on Python 3.12.

* Using mocked version 0.0.0 for testing instead of unknown.

* Removing template test.

* Removing snapshot updating action.

* trying rc3

* Using rc4

* Using prod ready 1.10 in CI.

* Updating integration test in Release workflow.

* Removing snapshottest installation in CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
coverage Improving the tests dependencies refactoring Better implementation of the same thing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobinTail @coveralls