Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for set_arg on macOS #748

Merged
merged 4 commits into from
Feb 10, 2019
Merged

Conversation

henryiii
Copy link
Contributor

Currently, macOS does not support set_arg with some datatypes. This was partially fixed in #737, but it does not work if the user does not manually specify the <boost/compute/types.hpp> header manually.

This PR is expected to fail to build on macOS on the first build. It will then need to be fixed.

See ddemidov/vexcl#227 for more info.

@henryiii henryiii changed the title Support for set_arg on macOS WIP: Support for set_arg on macOS Oct 16, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.766% when pulling c01065e on henryiii:add_test_mactypes into 7daca6f on boostorg:develop.

@ddemidov
Copy link
Contributor

@henryiii , can you try to add ddemidov@8f77efd to this PR? I believe that should fix the issue.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.766% when pulling 70aa256 on henryiii:add_test_mactypes into 7daca6f on boostorg:develop.

@ddemidov
Copy link
Contributor

I think the problem now is that test_kernels.cpp does not include compute/core.hpp. And we can not include types.hpp into the kernel.hpp, because types.hpp specializes some templates only declared in kernel.hpp. So may be the best solution for the failing test would be to either include core.hpp instead of kernel.hpp, or include types.hpp after kernel.hpp.

@henryiii
Copy link
Contributor Author

henryiii commented Oct 27, 2017

It bothers me that include order matters. Clang can even warn if includes are not sorted in alphabetical order.

Couldn't types include kernel, since it works on the contents?

Couldn't the types it specializes be declared first?

@coveralls
Copy link

coveralls commented Oct 28, 2017

Coverage Status

Coverage remained the same at 84.02% when pulling 4ab0939 on henryiii:add_test_mactypes into 827371a on boostorg:develop.

@henryiii henryiii changed the title WIP: Support for set_arg on macOS Support for set_arg on macOS May 15, 2018
@henryiii
Copy link
Contributor Author

I believe this fix is okay to add.

@jszuppe jszuppe self-assigned this Dec 27, 2018
@jszuppe jszuppe merged commit 8c7412f into boostorg:develop Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants