Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone logger for SkipCaller #8

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Clone logger for SkipCaller #8

merged 1 commit into from
Sep 8, 2021

Conversation

vearutop
Copy link
Member

@vearutop vearutop commented Sep 8, 2021

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 8, 2021

Lines Of Code

Language Files Lines Code Comments Blanks Complexity Bytes
Go 1 359 (+2) 270 (+1) 13 76 (+1) 55 6.6K (+100B)
Go (test) 4 398 (+2) 354 (+2) 13 31 5 11.6K (+146B)
YAML 6 (+1) 368 (+57) 318 (+52) 31 (+2) 19 (+3) 0 11.7K (+1.6K)

@github-actions
Copy link

github-actions bot commented Sep 8, 2021

Unit Test Coverage

total: (statements) 96.5%

Coverage diff with base branch
github.com/bool64/zapctxd/logger.go	New	92.9%
github.com/bool64/zapctxd/logger.go	make	100.0%
github.com/bool64/zapctxd/logger.go	SkipCaller	100.0%
github.com/bool64/zapctxd/logger.go	Debug	100.0%
github.com/bool64/zapctxd/logger.go	expandError	100.0%
github.com/bool64/zapctxd/logger.go	Info	100.0%
github.com/bool64/zapctxd/logger.go	Important	93.3%
github.com/bool64/zapctxd/logger.go	Warn	100.0%
github.com/bool64/zapctxd/logger.go	Error	93.3%
github.com/bool64/zapctxd/logger.go	get	100.0%
github.com/bool64/zapctxd/logger.go	CtxdLogger	0.0%
github.com/bool64/zapctxd/logger.go	ZapLogger	100.0%
total:	(statements)	96.5%

@github-actions
Copy link

github-actions bot commented Sep 8, 2021

API Changes

# summary
Inferred base version: v0.1.7
Suggested version: v0.2.0

@codecov-commenter
Copy link

Codecov Report

Merging #8 (238f370) into master (f030d1f) will increase coverage by 1.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   94.54%   95.69%   +1.15%     
==========================================
  Files           1        1              
  Lines         165       93      -72     
==========================================
- Hits          156       89      -67     
+ Misses          5        2       -3     
+ Partials        4        2       -2     
Flag Coverage Δ
unittests 95.69% <100.00%> (+1.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
logger.go 95.69% <100.00%> (+1.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f030d1f...238f370. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Sep 8, 2021

Benchmark Result

Benchmark diff with base branch
name          old time/op    new time/op    delta
SugaredZap-2    1.09µs ± 1%    1.11µs ± 7%    ~     (p=0.690 n=5+5)
CtxFull-2       2.67µs ± 7%    2.62µs ± 2%    ~     (p=0.643 n=5+5)
CtxLite-2       1.40µs ± 3%    1.40µs ± 1%    ~     (p=0.937 n=5+5)

name          old alloc/op   new alloc/op   delta
SugaredZap-2      256B ± 0%      256B ± 0%    ~     (all equal)
CtxFull-2         736B ± 0%      768B ± 0%  +4.35%  (p=0.008 n=5+5)
CtxLite-2         256B ± 0%      256B ± 0%    ~     (all equal)

name          old allocs/op  new allocs/op  delta
SugaredZap-2      1.00 ± 0%      1.00 ± 0%    ~     (all equal)
CtxFull-2         8.00 ± 0%      8.00 ± 0%    ~     (all equal)
CtxLite-2         1.00 ± 0%      1.00 ± 0%    ~     (all equal)
Benchmark result
name          time/op
SugaredZap-2  1.11µs ± 7%
CtxFull-2     2.62µs ± 2%
CtxLite-2     1.40µs ± 1%

name          alloc/op
SugaredZap-2    256B ± 0%
CtxFull-2       768B ± 0%
CtxLite-2       256B ± 0%

name          allocs/op
SugaredZap-2    1.00 ± 0%
CtxFull-2       8.00 ± 0%
CtxLite-2       1.00 ± 0%

@vearutop vearutop merged commit 2c1d16d into master Sep 8, 2021
@vearutop vearutop deleted the skip-caller-immutable branch September 8, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants