clarify fork semantics #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it more clear that context creation should generally occur _after_ fork. Also emphasize a little more strongly that ZeroMQ work should be done in the children, not the parent.
|
Nice work. Sorry for the confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially read this section of the guide to mean that one should create a single context before
fork, and share it across all children.Several explosions and much reading of the mailing list archives later, I now understand that the recommendation is actually the opposite: create contexts after
fork, in each child that needs to do zeromq work, and leave the parent just for process management.After confirming with a few other individuals that the wording in the section was a little confusing, I decided to take a stab at rewording it in line with the mailing list threads I found.
Thanks!
https://lists.zeromq.org/pipermail/zeromq-dev/2011-December/014900.html
https://lists.zeromq.org/pipermail/zeromq-dev/2010-September/006089.html
https://lists.zeromq.org/pipermail/zeromq-dev/2012-October/018887.html
https://lists.zeromq.org/pipermail/zeromq-dev/2013-August/022361.html