Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the display order of PAM messages #824

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Change the display order of PAM messages #824

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b4f1c2
Change the display order of PAM messages
Gliese852 Aug 7, 2023
a5184dc
Fixup: check if the user has a model directry in the PAM module
Gliese852 Aug 11, 2023
40720bb
Fixup: don't else after return and no det. notice
Gliese852 Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixup: don't else after return and no det. notice
  • Loading branch information
@Gliese852
Gliese852 committed Sep 6, 2023
commit 40720bbf87a7d650b629d4c86f8c4ea2c83ea3a1
2 changes: 1 addition & 1 deletion howdy/src/config.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

[core]
# Print that face detection is being attempted
detection_notice = true
detection_notice = false

# Print that face detection has timed out
timeout_notice = true
Expand Down
4 changes: 3 additions & 1 deletion howdy/src/pam/main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,9 @@ auto identify(pam_handle_t *pamh, int flags, int argc, const char **argv,
if (!std::ifstream(model_path)) {
return howdy_status(username, CompareError::NO_FACE_MODEL, config,
conv_function);
} else if (config.GetBoolean("core", "detection_notice", true)) {
}

if (config.GetBoolean("core", "detection_notice", true)) {
if ((conv_function(PAM_TEXT_INFO, S("Attempting facial authentication"))) !=
PAM_SUCCESS) {
syslog(LOG_ERR, "Failed to send detection notice");
Expand Down
Loading