[3.2] Switch Embed.ly to oEmbed API #6636
Conversation
| @@ -107,11 +107,13 @@ | |||
| */ | |||
| _update: function () { | |||
| var self = this, | |||
| url = 'https://api.embed.ly/1/oembed', | |||
| url = bolt.conf('paths.async') + 'oembed/request', | |||
There was a problem hiding this comment.
I've been trying to get away from string concatenation with paths. Can you assign url generator result to a data attribute in twig and fetch that here?
There was a problem hiding this comment.
All of it is getting re-done … I just went with what is there … maybe tomorrow, but I think that will have to wait for 3.3 TBH
| @@ -0,0 +1,99 @@ | |||
| <?php | |||
|
|
|||
| namespace Bolt\Request\Oembed; | |||
There was a problem hiding this comment.
I know this is making a request to (O)embed, but I don't think it belongs here. It has nothing to do with our Symfony HTTP Requests. Instead it's a service we are calling. I think Bolt\(O)embed would be better.
There was a problem hiding this comment.
Tomorrow, or anyone with push access
src/Controller/Async/Oembed.php
Outdated
| $oEmbedFactory = $this->app['oembed.factory']; | ||
|
|
||
| return $oEmbedFactory($url); | ||
| } |
There was a problem hiding this comment.
I kinda think having our own service class that wraps the ombed api that the controller could call here would be better. Then the controller doesn't have to know anything about the Embed\* code. But if there's a rush don't worry about it.
There was a problem hiding this comment.
It needs to be a factory, and I have over spend hugely my allowed computer time today.
So if someone wants to pick it up tonight, go for it … but a) this is 3.2; b) urgent
There was a problem hiding this comment.
Done … I got a better sense of what you meant after sleeping on it, and yeah 😄
|
Merging in! |
Does the job, gets us through, relies on the SF Forms token to be valid in editcontent …
… RFC
Fixes #6635