Throw ShopifyException when shopify request fails #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wryte
reviewed
Sep 22, 2021
| @@ -245,7 +247,7 @@ private function sendRequestToShopify(Request $request, array $cookies = [], $pa | |||
| case 429: | |||
| throw (new TooManyRequestsException($e->getMessage()))->setResponse($response); | |||
| default: | |||
| throw $e; | |||
| throw (new ShopifyException($e->getMessage()))->setResponse($response); | |||
There was a problem hiding this comment.
If you want a named exception for 500 errors I think you should make a new InternalException class and throw it when the status code is 500. Changing this for all other codes would potentially be a breaking change for other users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.