Skip to content

Commit

Permalink
Add GOOS=windows to lint-matrix (open-telemetry#30743)
Browse files Browse the repository at this point in the history
**Description:**

Add a lint step to CI with `GOOS=windows`. This will ensure that code
for Windows keeps a clean lint pass.

Until the lint Go cache is invalidated the step with `GOOS=windows` will
be a bit longer than the Linux step. I'm measuring in my fork to see
what we should expect after the cache is updated. I had an alternative
implementation using Windows runners instead, but, overall it required
separated Go caches and many more runners, running on Linux also ensures
that the step can also be run by contributors on their dev boxes.

**Link to tracking Issue:**
Related to #11557 and open-telemetry#27866, but, it doesn't fix any of the two.

**Testing:**
Validated that the step is passing for all components
  • Loading branch information
pjanotti committed Jan 24, 2024
1 parent dfb6b17 commit 6a2e178
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ jobs:
key: go-lint-build-${{ matrix.group }}-${{ runner.os }}-${{ hashFiles('**/go.sum') }}
- name: Lint
run: make -j2 golint GROUP=${{ matrix.group }}
- name: Lint with GOOS=windows
run: GOOS=windows make -j2 golint GROUP=${{ matrix.group }}
lint:
if: ${{ github.actor != 'dependabot[bot]' && always() }}
runs-on: ubuntu-latest
Expand Down

0 comments on commit 6a2e178

Please sign in to comment.