Skip to content

Commit

Permalink
Remove test step that can't be cleaned-up (#3067)
Browse files Browse the repository at this point in the history
The test TestApplication_StartAsGoRoutine is setting the metric level to none but there is no way to reset the flag to its default. This breaks the tests if one tries to run the tests multiple times in the same `go test` command. Since the setting was not required by tests opting to remove it.
  • Loading branch information
pjanotti committed Apr 30, 2021
1 parent ed89eb0 commit 1eb6d1a
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions service/application_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,6 @@ func TestApplication_StartAsGoRoutine(t *testing.T) {
}
app, err := New(params)
require.NoError(t, err)
app.Command().SetArgs([]string{
"--metrics-level=NONE",
})

appDone := make(chan struct{})
go func() {
Expand Down

0 comments on commit 1eb6d1a

Please sign in to comment.