Fix lexer span panic with carriage return #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to treating bare carriage return as an OS9-style newline, like v8.
Codecov Report
@@ Coverage Diff @@
## master #799 +/- ##
==========================================
+ Coverage 59.21% 59.26% +0.04%
==========================================
Files 155 155
Lines 9908 9924 +16
==========================================
+ Hits 5867 5881 +14
- Misses 4041 4043 +2
Continue to review full report at Codecov.
|
HalidOdat
approved these changes
Oct 5, 2020
Lan2u
approved these changes
Oct 6, 2020
|
Spec reference https://tc39.es/ecma262/#sec-line-terminators |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to treating bare carriage return as an OS9-style newline, like v8.
Fixes #771
Cursor::next_char, when we get a'\r', we now try to consume a'\n', and regardless of whether we find one we advance a newline. This has the effect of treating all of["\r\n", "\n", "\r"]as identical.Cursor::carriage_return, as it's now unused.