Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ops to exec module #635

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

jarredholman
Copy link
Contributor

@jarredholman jarredholman commented Aug 14, 2020

It changes the following:

  • Add support for executing ConditionalOp
  • Add support for executing continue statements (it is missing label support like break)
  • Remove the "match anything" branches where they weren't necessary.

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #635 into master will increase coverage by 0.13%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #635      +/-   ##
==========================================
+ Coverage   72.50%   72.64%   +0.13%     
==========================================
  Files         179      179              
  Lines       13376    13411      +35     
==========================================
+ Hits         9698     9742      +44     
+ Misses       3678     3669       -9     
Impacted Files Coverage Δ
boa/src/exec/block/mod.rs 61.11% <0.00%> (-7.64%) ⬇️
boa/src/exec/statement_list.rs 61.11% <0.00%> (-7.64%) ⬇️
boa/src/exec/switch/mod.rs 62.96% <0.00%> (-5.04%) ⬇️
boa/src/exec/iteration/mod.rs 60.31% <25.00%> (-1.51%) ⬇️
boa/src/exec/break_node/mod.rs 100.00% <100.00%> (ø)
boa/src/exec/conditional/mod.rs 90.00% <100.00%> (+6.66%) ⬆️
boa/src/exec/iteration/tests.rs 100.00% <100.00%> (ø)
boa/src/exec/mod.rs 70.73% <100.00%> (+0.97%) ⬆️
boa/src/exec/tests.rs 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d7791...bd54a38. Read the comment docs.

This was linked to issues Aug 20, 2020
@Razican Razican added bug Something isn't working enhancement New feature or request execution Issues or PRs related to code execution labels Aug 20, 2020
@Razican Razican added this to the v0.10.0 milestone Aug 20, 2020
@Razican
Copy link
Member

Razican commented Aug 20, 2020

Hi! I missed this PR, and #645 implemented part of it (the undefined part). Could you rebase?

* Node::ConditionalOp
* Node::Continue
@jarredholman
Copy link
Contributor Author

rebased. Hopefully it is straightforward?
I implemented them the same way as If and Break

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@Razican Razican merged commit c7531af into boa-dev:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Continue Panics Ternary Conditionals Panic
3 participants