Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged create into init for builtins #547

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Merged create into init for builtins #547

merged 1 commit into from
Jul 7, 2020

Conversation

HalidOdat
Copy link
Member

It changes the following:

  • Merged create into init

@HalidOdat HalidOdat added technical debt builtins PRs and Issues related to builtins/intrinsics labels Jul 4, 2020
@HalidOdat HalidOdat added this to the v0.10.0 milestone Jul 4, 2020
@codecov
Copy link

codecov bot commented Jul 4, 2020

Codecov Report

Merging #547 into master will decrease coverage by 0.12%.
The diff coverage is 73.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
- Coverage   68.25%   68.13%   -0.13%     
==========================================
  Files         172      172              
  Lines       10579    10546      -33     
==========================================
- Hits         7221     7185      -36     
- Misses       3358     3361       +3     
Impacted Files Coverage Δ
boa/src/builtins/boolean/tests.rs 100.00% <ø> (ø)
boa/src/builtins/number/tests.rs 100.00% <ø> (ø)
boa/src/builtins/string/tests.rs 100.00% <ø> (ø)
boa/src/builtins/symbol/tests.rs 100.00% <ø> (ø)
boa/src/builtins/array/mod.rs 80.80% <66.66%> (-0.10%) ⬇️
boa/src/builtins/boolean/mod.rs 34.48% <66.66%> (-2.19%) ⬇️
boa/src/builtins/console/mod.rs 29.41% <66.66%> (-0.83%) ⬇️
boa/src/builtins/error/range.rs 57.14% <66.66%> (-1.95%) ⬇️
boa/src/builtins/error/reference.rs 57.14% <66.66%> (-1.95%) ⬇️
boa/src/builtins/error/syntax.rs 33.33% <66.66%> (-3.04%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca0eaea...0589172. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jul 4, 2020

Benchmark for 8921266

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 405.8±18.98ns 396.7±15.58ns +2.29%
Array access (Execution) 12.7±0.62µs 12.8±0.43µs -0.78%
Array creation (Execution) 3.5±0.11ms 3.5±0.11ms 0.00%
Array pop (Execution) 1321.5±48.72µs 1289.3±50.17µs +2.50%
Boolean Object Access (Execution) 4.9±0.21µs 5.0±0.23µs -2.00%
Create Realm 137.9±7.25µs 140.0±6.00µs -1.50%
Dynamic Object Property Access (Execution) 6.6±0.24µs 6.5±0.33µs +1.54%
Expression (Lexer) 1882.1±62.55ns 1915.0±90.93ns -1.72%
Expression (Parser) 4.6±0.19µs 4.6±0.19µs 0.00%
Fibonacci (Execution) 918.1±40.76µs 933.2±51.81µs -1.62%
For loop (Execution) 20.8±0.99µs 21.4±1.41µs -2.80%
For loop (Lexer) 4.9±0.20µs 4.8±0.21µs +2.08%
For loop (Parser) 12.6±0.52µs 12.8±0.56µs -1.56%
Hello World (Lexer) 845.4±36.40ns 875.1±33.71ns -3.39%
Hello World (Parser) 2.0±0.09µs 2.1±0.09µs -4.76%
Long file (Parser) 5.7±0.20ms 5.7±0.15ms 0.00%
Number Object Access (Execution) 4.0±0.21µs 3.9±0.19µs +2.56%
Object Creation (Execution) 5.8±0.30µs 5.9±0.22µs -1.69%
RegExp (Execution) 68.1±2.37µs 66.7±2.92µs +2.10%
RegExp Literal (Execution) 72.3±3.15µs 72.5±4.93µs -0.28%
RegExp Literal Creation (Execution) 66.5±3.42µs 67.1±4.52µs -0.89%
Static Object Property Access (Execution) 6.2±0.23µs 6.0±0.25µs +3.33%
String Object Access (Execution) 8.3±0.34µs 8.2±0.49µs +1.22%
String comparison (Execution) 6.4±0.29µs 6.4±0.39µs 0.00%
String concatenation (Execution) 5.4±0.23µs 5.4±0.25µs 0.00%
String copy (Execution) 4.3±0.20µs 4.2±0.18µs +2.38%
Symbols (Execution) 3.8±0.18µs 3.8±0.16µs 0.00%

@github-actions
Copy link

github-actions bot commented Jul 7, 2020

Benchmark for face5f9

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 345.1±34.39ns 341.5±34.82ns +1.05%
Array access (Execution) 12.0±0.94µs 12.0±1.12µs 0.00%
Array creation (Execution) 3.2±0.31ms 3.4±0.37ms -5.88%
Array pop (Execution) 1197.0±96.02µs 1177.5±193.28µs +1.66%
Boolean Object Access (Execution) 4.5±0.34µs 4.5±0.27µs 0.00%
Create Realm 125.2±7.88µs 133.9±12.11µs -6.50%
Dynamic Object Property Access (Execution) 6.2±0.44µs 6.2±0.42µs 0.00%
Expression (Lexer) 1714.4±86.01ns 1924.7±195.45ns -10.93%
Expression (Parser) 4.2±0.41µs 4.1±0.33µs +2.44%
Fibonacci (Execution) 948.5±79.67µs 912.8±62.32µs +3.91%
For loop (Execution) 20.3±1.90µs 19.8±1.36µs +2.53%
For loop (Lexer) 4.4±0.30µs 4.6±0.47µs -4.35%
For loop (Parser) 11.7±0.99µs 12.4±1.19µs -5.65%
Hello World (Lexer) 787.4±41.61ns 806.2±55.55ns -2.33%
Hello World (Parser) 1905.5±182.77ns 1835.1±130.00ns +3.84%
Long file (Parser) 5.4±0.27ms 5.3±0.25ms +1.89%
Number Object Access (Execution) 3.6±0.30µs 3.7±0.37µs -2.70%
Object Creation (Execution) 5.6±0.46µs 5.6±0.50µs 0.00%
RegExp (Execution) 67.0±4.30µs 65.5±3.95µs +2.29%
RegExp Literal (Execution) 71.0±4.65µs 69.3±4.45µs +2.45%
RegExp Literal Creation (Execution) 70.7±6.20µs 71.0±7.76µs -0.42%
Static Object Property Access (Execution) 5.8±0.42µs 5.5±0.32µs +5.45%
String Object Access (Execution) 7.4±0.53µs 7.6±0.92µs -2.63%
String comparison (Execution) 6.6±0.76µs 6.1±0.44µs +8.20%
String concatenation (Execution) 5.1±0.22µs 5.1±0.36µs 0.00%
String copy (Execution) 4.3±0.45µs 4.3±0.42µs 0.00%
Symbols (Execution) 3.7±0.31µs 3.8±0.27µs -2.63%

@HalidOdat HalidOdat merged commit 1e82e7c into master Jul 7, 2020
@HalidOdat HalidOdat deleted the cleanup/init branch July 7, 2020 16:21
@HalidOdat HalidOdat mentioned this pull request Jul 11, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants