Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix arithmetic operations with no space #235

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

gomesalexandre
Copy link
Contributor

fix #224

@jasonwilliams
Copy link
Member

Thanks @gomesalexandre
I can see that breaking on '+' or '-' fixes the issue, but what is the preview_multiple_next() for? I don't see the usecase covered in the tests.

@gomesalexandre
Copy link
Contributor Author

@jasonwilliams thanks for the review!
It was needed to peek x indexes further in a peekable iterator as opposed to preview_next that only peeks the next() value.
I will add more test cases cases with <digit>e(<digit>) in the context of arithmetic operations.

@gomesalexandre gomesalexandre changed the title fix addition/subtraction with no space fix arithmetic operations with no space Jan 29, 2020
@jasonwilliams
Copy link
Member

@gomesalexandre did you want us to look over this again?

@gomesalexandre
Copy link
Contributor Author

@gomesalexandre did you want us to look over this again?

Would be lovely. Please let me know if you have some more ideas of tests that could be added in other places.

@jasonwilliams
Copy link
Member

could you rebase @gomesalexandre ? ive merged some clippy fixes

@gomesalexandre
Copy link
Contributor Author

could you rebase @gomesalexandre ? ive merged some clippy fixes

Here you go ✅

Copy link
Member

@jasonwilliams jasonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you

@jasonwilliams jasonwilliams merged commit 4488352 into boa-dev:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simple assignement with Number+"+" or Number+"-" does not work
2 participants