-
-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bnd-maven-plugin ConcurrentModificationException on latest OpenJDK 15 EA #3903
Comments
Would it be possible for you to re-run the build with Thanks for reporting! |
Figuring how to add the -X to the Travis install script was an adventure, but I finally got it. :) Link to the build and full log is here: https://travis-ci.org/github/oshi/oshi/jobs/673301183 Relevant (?) trace:
|
Based on the TreeMap issues, this may be the breaking change: |
We're also seeing that when calling Here's a stacktrace: I think the root cause is that bnd/biz.aQute.bndlib/src/aQute/bnd/osgi/Jar.java Lines 329 to 338 in 298c2b2
That is documented to be forbidden in
|
yeah, we should reverse the algorithm and do a pass adding the parents instead. |
Once the build completes, you should be able to test with the 5.1.0-SNAPSHOT build. See https://github.com/bndtools/bnd/blob/master/maven/README.md#using-the-latest-development-snapshot-build-of-the-bnd-maven-plugins. |
I can confirm 5.1.0-SNAPSHOT resolves the maven plugin issue. Thanks for the quick turnaround. |
@bjhargrave Would it be possible to release this fix in 5.0.2 or is 5.1.0 about to be released soon? |
I would like to go with releasing 5.1.0 soon since there are some other commits needed to support Java 15 and build correct bundles. I will discuss with the other maintainers. |
A release soon would be most welcome as we are seeing this problem blow up Apache Commons CSV builds on Java 15: |
Looks like only one issue to go which says it'll get done this week... |
Yes, we are trying to get to 5.1.0.RC1 by Friday! Busy trying to get the last bits in! |
@bjhargrave Good luck then! :-) |
@bjhargrave |
Yes! We have released 5.1.0.RC1. About to kick off the 5.1.0.RC2 build. |
Where are the RC published ? I'd like to get it into the felix maven-bundle-plugin asap. |
@pkriens strangely, the update-rc points to snapshots, not the rc : https://bndtools.jfrog.io/bndtools/update-rc/biz/aQute/bnd/biz.aQute.bndlib/ |
The RCs are snapshots |
Ok, I'll wait for the GA then. |
For all interested parties, Bnd 5.1.0 was released yesterday. So you can update to it for Java 15 support. |
Fails here too. |
I am on oracle btw. |
Which version of the plugin are you using? This issue was fixed a good long
while ago.
…On Sat., Mar. 6, 2021, 4:03 p.m. momomo, ***@***.***> wrote:
I am on oracle btw.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3903 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABD2THNGHB5G222NON5WL3TCKKDXANCNFSM4MFHJA6A>
.
|
Well, the project i was using was using first the old one 2.5.3. So I updated to 4.2.1 because that is what it says here: https://felix.apache.org/components/bundle-plugin/plugin-info.html However, I found out that there is an even newer version later, 5.1.1 using search.maven.org. Now it is fine. Howeveer, someone ought to update that website! |
The link you reference is for Apache Felix and it's maven-bundle-plugin which is not the same as Bnd's bnd-maven-plugin. While they both use Bnd internally, they are distinct plugins from different teams. |
Current version of SpotBugs does not work on JDK15, hence disable it when we detect JDK15 build environment. Also, maven-bundle-plugin fails in bndlib, as reported in bndtools/bnd#3903. Change-Id: Ie38e7b81d3eff030b0f7f135666dc3cc91c4d8a7 Signed-off-by: Robert Varga <[email protected]>
--- Signed-off-by: Peter Kriens <[email protected]> Signed-off-by: Peter Kriens <[email protected]>
We may need to make multiple modifications to the directories map when adding a resource. computeIfAbsent does not allow the mapping function to modify the map. Fixes bndtools#3903 Signed-off-by: BJ Hargrave <[email protected]> Signed-off-by: BJ Hargrave <[email protected]>
The current plugin fails when building against JDK 15+ See bndtools/bnd#3903
project build fails - bnd-maven-plugin errors with ConcurrentModificationException bndtools/bnd#3903
This avoids build issues on recent JDKs, see bndtools/bnd#3903
This avoids build issues on recent JDKs, see bndtools/bnd#3903
This avoids build issues on recent JDKs, see bndtools/bnd#3903 DEVSIX-6909
Bump maven-bundle-plugin to 5.1.6 This avoids build issues on recent JDKs, see bndtools/bnd#3903 DEVSIX-6909 Autoported commit. Original commit hash: [8eca22a74] Manual files: pom.xml
The older versions throw ConcurrentModificationException. See bndtools/bnd#3903
* Update biz.aQute.bnd to 6.4.0 The older versions throw ConcurrentModificationException. See bndtools/bnd#3903
I've been using the
bnd-maven-plugin
for a long time with no issues and have not made any recent configuration changes. Beginning tonight, the Travis CI build is failing on the OpenJDK15 (early access) build with this error:The Java version used is:
Link to failing Travis CI job: https://travis-ci.org/github/oshi/oshi/jobs/673288964
It worked as recently as a two days ago on a slightly earlier EA build:
Link to passing Travis CI job from 2 days ago: https://travis-ci.org/github/oshi/oshi/jobs/672568551
Other relevant version strings:
Relevant portions of my POM configuration:
Happy to help troubleshoot but I have no idea where to even start!
The text was updated successfully, but these errors were encountered: