durations from int64 to float64 for short tests #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Short tests would be truncated to 0s. For thousands of short tests, this is not useful. This fixes that issue.
cavalheiro
approved these changes
Jul 3, 2020
|
This would be very helpful! |
|
@cavalheiro thank you!! |
|
@cavalheiro How do I merge? lolol |
|
@rms1000watt I do not have merge rights. Ping @bndr, can you please merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short tests would be truncated to 0s. For thousands of short tests, this is not useful. This fixes that issue.