[R4R]prefetch state by applying the transactions within one block #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
changed the title
unclezoro
changed the title
yutianwu
reviewed
Jan 10, 2022
yutianwu
reviewed
Jan 10, 2022
yutianwu
approved these changes
Jan 10, 2022
j75689
reviewed
Jan 10, 2022
j75689
approved these changes
Jan 10, 2022
KeefeL
reviewed
Jan 10, 2022
core/state_prefetcher.go
Outdated
| @@ -35,42 +36,60 @@ type statePrefetcher struct { | |||
| engine consensus.Engine // Consensus engine used for block rewards | |||
| } | |||
|
|
|||
| // newStatePrefetcher initialises a new statePrefetcher. | |||
There was a problem hiding this comment.
Should be NewStatePrefetcher
KeefeL
approved these changes
Jan 10, 2022
fix ut
This was referenced Jan 23, 2022
Merged
unclezoro
added a commit
that referenced
this pull request
Feb 17, 2022
* prefetch state by apply transactions within one block * resolve comments * stop prefetch once process is done * update comments fix ut
KeefeL
pushed a commit
to KeefeL/bsc
that referenced
this pull request
Jun 6, 2022
…b-chain#704) * prefetch state by apply transactions within one block * resolve comments * stop prefetch once process is done * update comments fix ut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By improving the snapshot clean cache hit rate, we can improve the capacity of BSC further.
Rationale
According to the test, the cache hitting rate on BSC is about 94%, while the miss 6% IO will cost 32% of execution time.
We try to preload the state from DB by applying the transactions in advance. It turns out the execution time was reduced by 30%-40%
Example
Verified on testnet and mainnet.
Changes
No impact to users