Accelerate get diff accounts with scope #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ffc65d
to
d540c1c
Compare
yutianwu
reviewed
Nov 5, 2021
internal/ethapi/api.go
Outdated
| Transactions: make([]types.DiffAccountsInTx, 0), | ||
| } | ||
|
|
||
| if needReplay, err := s.needToReplay(ctx, block, accounts); !needReplay { |
There was a problem hiding this comment.
can we test err first if needReplay, err := s.needToReplay(ctx, block, accounts); err != nil {
Signed-off-by: Keefe-Liu <[email protected]>
yutianwu
approved these changes
Nov 5, 2021
unclezoro
approved these changes
Nov 8, 2021
This was referenced Nov 10, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add needToReplay condition to accelerate eth_getDiffAccountsWithScope
Rationale
Replay the whole block spend too much time, actually we need't do that, so add an quick way to decide whether to replay the block.
Example
add an example CLI or API response...
Changes
Notable changes:
Preflight checks
make build)make test)Already reviewed by
...
Related issues
... reference related issue #'s here ...