core: LoadChainConfig return the predefined config for built-in networks firstly #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buddh0
force-pushed
the
LoadChainConfig_builtin_net
branch
from
1cefe71
to
d37b04f
Compare
0xbundler
reviewed
Dec 18, 2023
galaio
previously approved these changes
Dec 18, 2023
zzzckck
previously approved these changes
Dec 18, 2023
buddh0
force-pushed
the
LoadChainConfig_builtin_net
branch
from
a76452e
to
849d5a2
Compare
galaio
approved these changes
Dec 18, 2023
zzzckck
approved these changes
Dec 18, 2023
This was referenced Dec 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
core: LoadChainConfig return the predefined config for built-in networks firstly
Rationale
and they should not be configured in the
config.tomlso return the predefined config
geth initto upgrade the chain config,so we just stop supporting read chain config from the
config.toml.by doing this, logic about chain config can be simplified.
Example
add an example CLI or API response...
Changes
Notable changes: